-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(jaeger): better configuration pipeline. #748
feat(jaeger): better configuration pipeline. #748
Conversation
- Separate agent pipeline and collector pipeline. it's now `new_agent_pipeline` and `new_collector_pipeline` - Add `Configurable` trait to include common attributes shared by agent pipeline and collector pipeline. - Removed `with_tag` method. - Make build in http client additive. `surf_collector_client`, `isahc_collector_client`, etc. are now just allow user to choose the http client.
Codecov Report
@@ Coverage Diff @@
## main #748 +/- ##
==========================================
- Coverage 70.19% 69.01% -1.18%
==========================================
Files 108 111 +3
Lines 8804 8973 +169
==========================================
+ Hits 6180 6193 +13
- Misses 2624 2780 +156
Continue to review full report at Codecov.
|
I think I have a way to resolve the msrv error. But it will expose |
What would we need to bump it to? |
Dig a little bit and looks like the error was relaxed by rust-lang/rust#90586. |
…o meet MSRV requirement. Rename CommonConfig to TransformationConfig.
1d1f03d
to
ac74d94
Compare
I think the jaeger configuration pipeline has been a little hard to understand between agent's configurations and collector's configurations. This PR:
new_agent_pipeline
andnew_collector_pipeline
. Note that this means if the collector exporter to start we will not fall back to agent exporter.AgentPipeline
andCollectorPipeline
to configure agent exporter and collector exporter.auto_batches_split
,max_packet_size
)with_agent_endpoint
towith_endpoint
as agent pipeline and collector pipeline are separate now. Similar to collector.Configurable
trait to include common attributes shared by agent pipeline and collector pipeline.with_tag
method.surf_collector_client
,isahc_collector_client
,reqwest_collector_client
,reqwest_collector_blocking_client
) additive.collector_client
andwasm_collector_client
additive. Now users can start a wasm collector usingwasm_collector_client
.ConfigError
for all error from the builder. Most of them are invalid value like string that cannot convert to URIOverall we seprate the collector configurations from agent configurations to prevent users set unrelevant configurations. For example,
The downside is now if the collector fails to build, we no longer fall back to agent.
BREAKING CHANGES:
As we separate the agent pipeline and collector pipeline. The user must understand which one they are using and change
new_pipeline
tonew_collector_pipeline
ornew_agent_pipeline
.Functions that contains
agent
orcollector
will no longer contains it as the pipeline are different. For example,with_collector_username
will now bewith_username
.For users using build in http client(isahc, reqwest, reqwest-blocking or surf). They need to add a new function to pipeline that explicitly point out the http client they want to use.
#736