Support custom timer via FormatTime
#49
Conversation
| if let Some(timer) = self.timer.as_ref() { | ||
| timer | ||
| // TODO(TmLev): Wants `Writer`, have `event_buf`. | ||
| .format_time() | ||
| .expect("Unable to write time to buffer"); |
There was a problem hiding this comment.
I don't know how to actually call format_time() with event_buf since it requires &mut Writer which cannot be instantiated because of the private constructors:
https://github.com/tokio-rs/tracing/blob/8030eb9dfb56201b1b0843f6d6105eb89e3660ed/tracing-subscriber/src/fmt/format/mod.rs#L421-L431
There was a problem hiding this comment.
Whoops, that's a bit of an issue. If the lack of a timer blocking you, let's not wait on tracing-subscriber. We can add a dependency on time directly and provide a few out-of-the-box formatters. I'm not sure if we should have our own FormatTime trait similar to that of tracing-subscrber's, but if we do, then I think we can probably tweak it so that it works well with tracing-tree (e.g., you can specify what writer you want to use here).
Getting tracing-tree onto tracing-subscriber's FormatEvent/FormatTime infrastructure might be a bigger lift that I don't want to commit to spending time on now.
There was a problem hiding this comment.
I opened an issue about this in tracing repo: tokio-rs/tracing#2223. I suggest we wait for an answer from Eliza a little. If she agrees to make constructor public, then problem is solved (hopefully). If not, we can always mimic FormatTime for tracing-tree.
There was a problem hiding this comment.
I'm aware of the issue you opened; check who the co-author of tracing-subscriber is :).
In any case, I think that a proper solution for this issue would be build atop of tokio-rs/tracing#2132 (but that issue is slightly orthogonal to this), but I'm pretty sure that we don't want to make a decision about the API in tracing-subscriber just yet. If we do, it'll require some larger changes across tracing-subscriber, and one of the best ways to determine what that API should be is to vendor the FormatTime trait in tracing-tree and experiment here. It has the nice side-effect of unblocking you as well.
There was a problem hiding this comment.
I see, thanks for elaborating. I'll try to sketch an API similar to FormatTime from tracing-subscriber.
There was a problem hiding this comment.
Should I hide FormatTime under the feature flag? Doing so complicates things with generic parameters and where clauses.
There was a problem hiding this comment.
it can be hidden behind a feature flag, but i wouldn't be too worried, honestly
|
Superseded by #56. |
Resolves #48.