-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support custom timer via FormatTime
#49
Closed
Closed
Changes from 2 commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know how to actually call
format_time()
withevent_buf
since it requires&mut Writer
which cannot be instantiated because of the private constructors:https://github.com/tokio-rs/tracing/blob/8030eb9dfb56201b1b0843f6d6105eb89e3660ed/tracing-subscriber/src/fmt/format/mod.rs#L421-L431
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops, that's a bit of an issue. If the lack of a timer blocking you, let's not wait on
tracing-subscriber
. We can add a dependency ontime
directly and provide a few out-of-the-box formatters. I'm not sure if we should have our ownFormatTime
trait similar to that oftracing-subscrber
's, but if we do, then I think we can probably tweak it so that it works well withtracing-tree
(e.g., you can specify what writer you want to use here).Getting
tracing-tree
onto tracing-subscriber'sFormatEvent
/FormatTime
infrastructure might be a bigger lift that I don't want to commit to spending time on now.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I opened an issue about this in
tracing
repo: tokio-rs/tracing#2223. I suggest we wait for an answer from Eliza a little. If she agrees to make constructor public, then problem is solved (hopefully). If not, we can always mimicFormatTime
fortracing-tree
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm aware of the issue you opened; check who the co-author of
tracing-subscriber
is :).In any case, I think that a proper solution for this issue would be build atop of tokio-rs/tracing#2132 (but that issue is slightly orthogonal to this), but I'm pretty sure that we don't want to make a decision about the API in
tracing-subscriber
just yet. If we do, it'll require some larger changes acrosstracing-subscriber
, and one of the best ways to determine what that API should be is to vendor theFormatTime
trait intracing-tree
and experiment here. It has the nice side-effect of unblocking you as well.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, thanks for elaborating. I'll try to sketch an API similar to
FormatTime
fromtracing-subscriber
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I hide
FormatTime
under the feature flag? Doing so complicates things with generic parameters andwhere
clauses.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it can be hidden behind a feature flag, but i wouldn't be too worried, honestly