Linter fixes

davidmoreno · Dec 25, 2023 · 426ada2 · 426ada2
1 parent 3f92097
commit 426ada2
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 9 deletions.
diff --git a/include/rtpmidid/rtppeer.hpp b/include/rtpmidid/rtppeer.hpp
@@ -168,15 +168,15 @@ struct fmt::formatter<rtpmidid::rtppeer_t::status_e>
       name = "CONNECTED";
       break;
     }
-    return formatter<std::string_view>::format(name, ctx);
+    return formatter<std::string_view>::format(name, ctx); // NOLINT
   }
 };
 
 template <>
 struct fmt::formatter<rtpmidid::rtppeer_t::port_e>
     : formatter<std::string_view> {
   auto format(rtpmidid::rtppeer_t::port_e c, format_context &ctx) {
-    const char *name = "UNKNOWN";
+    const char *name = "UNKNOWN"; // NOLINT
     switch (c) {
     case rtpmidid::rtppeer_t::port_e::MIDI_PORT:
       name = "MIDI_PORT";
@@ -185,15 +185,15 @@ struct fmt::formatter<rtpmidid::rtppeer_t::port_e>
       name = "CONTROL_PORT";
       break;
     }
-    return formatter<std::string_view>::format(name, ctx);
+    return formatter<std::string_view>::format(name, ctx); // NOLINT
   }
 };
 
 template <>
 struct fmt::formatter<rtpmidid::rtppeer_t::disconnect_reason_e>
     : formatter<std::string_view> {
   auto format(rtpmidid::rtppeer_t::disconnect_reason_e c, format_context &ctx) {
-    const char *name = "UNKNOWN";
+    const char *name = "UNKNOWN"; // NOLINT
     switch (c) {
     case rtpmidid::rtppeer_t::disconnect_reason_e::CANT_CONNECT:
       name = "CANT_CONNECT";
@@ -217,6 +217,6 @@ struct fmt::formatter<rtpmidid::rtppeer_t::disconnect_reason_e>
       name = "NETWORK_ERROR";
       break;
     }
-    return formatter<std::string_view>::format(name, ctx);
+    return formatter<std::string_view>::format(name, ctx); // NOLINT
   }
 };
diff --git a/include/rtpmidid/signal.hpp b/include/rtpmidid/signal.hpp
@@ -95,7 +95,7 @@ template <typename... Args> class signal_t {
       if (this->slots->find(f.first) == this->slots->end())
         continue; // this element was removed while looping, do not call
       DEBUG0("{}::signal_t::() calling {}", (void *)this, f.first);
-      f.second(std::forward<Args>(args)...);
+      f.second(args...);
       DEBUG0("{}::signal_t::() called {}", (void *)this, f.first);
     }
     DEBUG0("{}::signal_t::() END", (void *)this);

diff --git a/src/aseq.cpp b/src/aseq.cpp
@@ -125,8 +125,7 @@ aseq_t::~aseq_t() {
  */
 void aseq_t::read_ready() {
   snd_seq_event_t *ev;
-  int pending;
-  while ((pending = snd_seq_event_input(seq, &ev)) > 0) {
+  while (snd_seq_event_input(seq, &ev) > 0) {
     // DEBUG("ALSA MIDI event: {}, pending: {} / {}", ev->type, pending,
     // snd_seq_event_input_pending(seq, 0));
 

diff --git a/src/control_socket.cpp b/src/control_socket.cpp
@@ -131,7 +131,6 @@ void control_socket_t::data_ready(int fd) {
       ERROR(
           "Could not send msg too long to control socket! Closing connection.");
       ::close(fd);
-      fd = -1;
     }
     return;
   }