[Fix] safe version attribute access in _check_resource_uniqueness (#7376

) (#7405)

safe version attribute access in _check_resource_uniqueness

.changes/unreleased/Fixes-20230418-135257.yaml

@@ -0,0 +1,6 @@
+kind: Fixes
+body: safe version attribute access in _check_resource_uniqueness
+time: 2023-04-18T13:52:57.367108-04:00
+custom:
+  Author: MichelleArk
+  Issue: "7375"

core/dbt/contracts/graph/nodes.py

@@ -119,6 +119,10 @@ def should_store_failures(self):
     def is_relational(self):
         return self.resource_type in NodeType.refable()
 
+    @property
+    def is_versioned(self):
+        return self.resource_type in NodeType.versioned() and self.version is not None
+
     @property
     def is_ephemeral(self):
         return self.config.materialized == "ephemeral"

core/dbt/graph/selector_methods.py

@@ -210,8 +210,7 @@ def search(self, included_nodes: Set[UniqueId], selector: str) -> Iterator[Uniqu
         """
         parsed_nodes = list(self.parsed_nodes(included_nodes))
         for node, real_node in parsed_nodes:
-            is_versioned = isinstance(real_node, ModelNode) and real_node.version is not None
-            if self.node_is_match(selector, real_node.fqn, is_versioned):
+            if self.node_is_match(selector, real_node.fqn, real_node.is_versioned):
                 yield node
 
 

core/dbt/parser/manifest.py

@@ -1106,7 +1106,7 @@ def _check_resource_uniqueness(
         full_node_name = str(relation)
 
         existing_node = names_resources.get(name)
-        if existing_node is not None and existing_node.version is None:
+        if existing_node is not None and not existing_node.is_versioned:
             raise dbt.exceptions.DuplicateResourceNameError(existing_node, node)
 
         existing_alias = alias_resources.get(full_node_name)

test/unit/test_graph_selection.py

@@ -42,6 +42,7 @@ def _get_manifest(graph):
             resource_type=NodeType.Model,
             empty=False,
             config=mock.MagicMock(enabled=True),
+            is_versioned=False,
         )
         nodes[unique_id] = node
 

test/unit/test_linker.py

@@ -25,6 +25,7 @@ def _mock_manifest(nodes):
                 empty=False,
                 config=config,
                 fqn=["pkg", n],
+                is_versioned=False,
             )
             for n in nodes
         }