Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] safe version attribute access in _check_resource_uniqueness #7376

Merged
merged 4 commits into from
Apr 18, 2023

Conversation

MichelleArk
Copy link
Contributor

resolves #7375

Description

Checklist

@cla-bot cla-bot bot added the cla:yes label Apr 17, 2023
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@MichelleArk MichelleArk marked this pull request as ready for review April 18, 2023 18:13
@MichelleArk MichelleArk requested a review from a team April 18, 2023 18:13
@MichelleArk MichelleArk requested review from a team as code owners April 18, 2023 18:13
@MichelleArk MichelleArk merged commit a87275a into main Apr 18, 2023
@MichelleArk MichelleArk deleted the 7375/fix-versioned-attribute-error branch April 18, 2023 18:22
@jtcohen6
Copy link
Contributor

@MichelleArk I'd be supportive of backporting this to 1.5.latest, if you think we should

@MichelleArk
Copy link
Contributor Author

Definitely! Thanks for the reminder 🙏

github-actions bot pushed a commit that referenced this pull request Apr 18, 2023
)

safe version attribute access in _check_resource_uniqueness

(cherry picked from commit a87275a)
MichelleArk pushed a commit that referenced this pull request Apr 20, 2023
) (#7405)

safe version attribute access in _check_resource_uniqueness
@aranke aranke mentioned this pull request May 9, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants