Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorporate unique key into scd_id in Snapshot "check" strategy #1588

Closed
drewbanin opened this issue Jul 5, 2019 · 1 comment
Closed

Incorporate unique key into scd_id in Snapshot "check" strategy #1588

drewbanin opened this issue Jul 5, 2019 · 1 comment
Labels
bug Something isn't working
Milestone
Wilt Chamberlain

Comments

@drewbanin
Copy link
Contributor

drewbanin commented Jul 5, 2019 •
edited
Loading

Issue

Issue description

To investigate: The dbt_scd_id generated for Snapshots does not necessarily include the unique key for the record. This means that two different records which share a set of check_cols could conflict. Instead, the dbt_scd_id column should be generated from the unique_key + check_cols, that way each individual record can be tracked independently.

TODO:

  • Verify that this is an issue
  • Verify that including the unique_key in the hash is a viable solution
@drewbanin drewbanin changed the title Incorporate unique key into scd_id in Snapshot "check" st Incorporate unique key into scd_id in Snapshot "check" strategy Jul 5, 2019
drewbanin added a commit that referenced this issue Jul 6, 2019
@drewbanin
(#1588) fix for dupe check_cols values in snapshot strategy
08d79cc
@drewbanin drewbanin added this to the Wilt Chamberlain milestone Jul 8, 2019
@drewbanin drewbanin added the bug Something isn't working label Jul 8, 2019
@drewbanin
Copy link
Contributor Author

Fixed in #1590

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
Wilt Chamberlain
Development

No branches or pull requests
1 participant
@drewbanin