[Wilt Chamberlain] fix for dupe check_cols values in snapshot strategy #1590
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
target_database
optional in snapshots (I'm not sure if the way I implemented it was the best way to do this)dbt_scd_id
hash with the unique id of the row, avoiding hash conflictsThe existing behavior of the
check_cols
strategy could fail in a subtle way if the specifiedcheck_cols
values for two rows were equivalent:Given:
Assume that bob's color changes to blue:
The generated snapshot query would invalidate any records where
dbt_scd_id = md5('red')
. This would inadvertently update alice as well as bob!This PR includes the unique id in the hash, so the resulting snapshot would invalidate records where
dbt_scd_id = md5('2' || 'red')
, which is localized to just bob's record.