Fix for models which transition from views to incremental #1293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the target relation is a non-table (probably a view) then dbt should return False from the is_incremental() macro. The materialization will drop this relation before running the model code as a `create table as` statement, so the incremental filter would likely be invalid.
beckjake
approved these changes
Feb 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1292
If the target relation is a non-table (probably a view) then dbt should return
Falsefrom theis_incremental()macro. The incremental materialization will drop this relation before running the model code as acreate table asstatement, so the incremental filter should not be appliedto the model sql.
Added a test which, before the code change, results in: