Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for models which transition from views to incremental #1293

Merged
merged 2 commits into from
Feb 13, 2019
Merged

Fix for models which transition from views to incremental #1293

merged 2 commits into from
Feb 13, 2019

Commits on Feb 13, 2019

  1. (fixes #1292) Check for relation type in is_incremental() 

    If the target relation is a non-table (probably a view) then dbt
should return False from the is_incremental() macro. The
materialization will drop this relation before running the model
code as a `create table as` statement, so the incremental filter
would likely be invalid.
    @drewbanin
    drewbanin committed Feb 13, 2019
    Configuration menu
    Copy the full SHA
    2c94e9e View commit details
    Browse the repository at this point in the history

  2. Merge branch 'dev/stephen-girard' into fix/incremental-from-view

    @drewbanin
    drewbanin committed Feb 13, 2019
    Configuration menu
    Copy the full SHA
    2847f69 View commit details
    Browse the repository at this point in the history