Change Graph logger call sites #4165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 18 commits
October 29, 2021 10:06
nathaniel-may
changed the base branch from
feature/structured-logging
to
client-call-sites
emmyoop
approved these changes
Oct 29, 2021
core/dbt/events/types.py
Outdated
| @@ -264,3 +306,4 @@ def cli_msg(self) -> str: | |||
| SystemStdOutMsg(bmsg=b'') | |||
| SystemStdErrMsg(bmsg=b'') | |||
| SystemReportReturnCode(code=0) | |||
| SelectorReportInvalidSelector(selector_methods={'':''}, spec_method='', raw_spec='') | |||
There was a problem hiding this comment.
missing SelectorAlertAllUnusedNodes and SelectorAlertUpto3UnusedNodes
| @@ -103,11 +94,11 @@ def get_nodes_from_criteria( | |||
| try: | |||
| collected = self.select_included(nodes, spec) | |||
| except InvalidSelectorException: | |||
| valid_selectors = ", ".join(self.SELECTOR_METHODS) | |||
There was a problem hiding this comment.
Is there a reason to move this into SelectorReportInvalidSelector?
There was a problem hiding this comment.
I'm trying to take the approach where the event represents all the necessary data, and the responsibility to turn data into human-readable strings is entirely up to the event methods. valid_selectors looks like it's entirely about turning data into strings so I moved it.
There was a problem hiding this comment.
Makes sense. Just want to make sure I'm consistent.
Base automatically changed from
client-call-sites
to
feature/structured-logging
October 29, 2021 20:35
emmyoop
added a commit
that referenced
this pull request
Nov 8, 2021
graph call sites for structured logging
emmyoop
added a commit
that referenced
this pull request
Nov 8, 2021
graph call sites for structured logging
kwigley
pushed a commit
that referenced
this pull request
Nov 9, 2021
graph call sites for structured logging
nathaniel-may
pushed a commit
that referenced
this pull request
Nov 9, 2021
graph call sites for structured logging
iknox-fa
pushed a commit
that referenced
this pull request
Feb 8, 2022
graph call sites for structured logging automatic commit by git-black, original commits: 51d8440
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
waiting to merge till #4163 is in the feature branch, but it's ready for review.
Description
Changes log call sites in graph module
TODO:
Checklist
CHANGELOG.mdand added information about my change