-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change Graph logger call sites #4165
Merged
Merged
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
b14c1e3
SparseCheckoutSubdirectory
c412b2b
CheckoutRevision
535677b
GitStatusUpdatingExistingDependency
a1eb792
rename with prefix
2659dd1
GitProgressPullingNewDependency
baee982
GitNothingToDo
e744ec5
GitUpdatedCheckoutRange
b60ebb3
GitProgressCheckedOutAt
b906e83
lint fixes
1e8171b
remove unused logger import
34188f9
registry.py
20d0bff
SystemErrorRetrievingModTime
626ee64
SystemCouldNotWrite
f8585d0
lint fixes
d4a6cff
SystemExecutingCmd
5d62a2b
SystemStdOutMsg & SystemStdErrMsg
b16da8b
SystemReportReturnCode
31309e7
SelectorAlertUpto3UnusedNodes & SelectorAlertAllUnusedNodes
5bf0b8e
SelectorReportInvalidSelector
ab82e6a
minor fixes
3d74d5a
resolve merge conflicts
89f2adf
fix merge issues
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason to move this into
SelectorReportInvalidSelector
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm trying to take the approach where the event represents all the necessary data, and the responsibility to turn data into human-readable strings is entirely up to the event methods.
valid_selectors
looks like it's entirely about turning data into strings so I moved it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense. Just want to make sure I'm consistent.