fix MP_CONTEXT is not JSON serializable #6650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
1 similar comment
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
ChenyuLInx
requested review from
MichelleArk,
stu-k,
iknox-fa and
aranke
and removed request for
mikealfare and
colin-rogers-dbt
ChenyuLInx
changed the title
MichelleArk
reviewed
Jan 19, 2023
core/dbt/utils.py
Outdated
| @@ -642,7 +642,10 @@ def args_to_dict(args): | |||
| dict_args = {} | |||
| # remove args keys that clutter up the dictionary | |||
| for key in var_args: | |||
| if key == "cls": | |||
| if key.lower() in var_args and key == key.upper(): | |||
| # skip all caped keys being introduced by Flags in dbt.cli.flags | |||
There was a problem hiding this comment.
typo/nit: 'caped' - perhaps you meant 'capped'?
MichelleArk
approved these changes
Jan 19, 2023
ChenyuLInx
added a commit
that referenced
this pull request
Jan 20, 2023
This was referenced Jan 31, 2023
This was referenced Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6509
This fixes the issue by adding logic to skip duplicated capped attributes introduced in Flags, also remove
mp_contextthat is added.Test that failed before now passes
tests/adapter/dbt/tests/adapter/grants/test_snapshot_grants.py