Seed and freshness works with click #6651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Jan 19, 2023
jtcohen6
reviewed
Jan 19, 2023
core/dbt/cli/main.py
Outdated
| @@ -436,10 +444,21 @@ def source(ctx, **kwargs): | |||
| @p.threads | |||
| @p.vars | |||
| @requires.preflight | |||
| @requires.profile | |||
| @requires.project | |||
| def freshness(ctx, **kwargs): | |||
| """Snapshots the current freshness of the project's sources""" | |||
There was a problem hiding this comment.
[Not needed for this PR] Let's definitely remove the word "snapshots" from this help text, when we get to DX review (#6546). We renamed this command for a reason, to disambiguate it from dbt snapshot.
MichelleArk
approved these changes
Jan 19, 2023
stu-k
reviewed
Jan 19, 2023
Comment on lines
+459
to
+461
| snapshot_freshness = copy(cli.commands["source"].commands["freshness"]) # type: ignore | ||
| snapshot_freshness.hidden = True | ||
| cli.commands["source"].add_command(snapshot_freshness, "snapshot-freshness") # type: ignore |
There was a problem hiding this comment.
Like we just talked about in standup, if you could add comments above this and ls to explain what we're doing that would be very helpful!
|
More tests pass with @MichelleArk 's change in, only test fail for source is related to flags, doing that as separate. The tests fail for freshness is due to |
This was referenced Jan 31, 2023
This was referenced Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5553
Resolves #5555
Adding seed and freshness together since we need seed to in functional test setup to run freshness test.
Here's the test passing after this change. And I included changes at #6650 to get away with serialization error.
The failed tests are gonna be resolved by @MichelleArk 's change at #5549 with the updated parameters.