Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix target-path not working for sources.json #7412

Merged
merged 1 commit into from
Apr 20, 2023
Merged

Conversation

ChenyuLInx
Copy link
Contributor

@ChenyuLInx ChenyuLInx commented Apr 19, 2023

resolves #7411
Edited test would fail before the fix

@ChenyuLInx ChenyuLInx requested review from aranke and iknox-fa April 19, 2023 21:23
@ChenyuLInx ChenyuLInx requested a review from a team as a code owner April 19, 2023 21:23
@cla-bot cla-bot bot added the cla:yes label Apr 19, 2023
@ChenyuLInx ChenyuLInx force-pushed the cl/targe_path_param branch from 23c5155 to adfe9ed Compare April 19, 2023 22:42
@ChenyuLInx ChenyuLInx changed the title fix missing target dir fix target dir not working for sources.json Apr 19, 2023
@ChenyuLInx ChenyuLInx changed the title fix target dir not working for sources.json fix target-path not working for sources.json Apr 19, 2023
@ChenyuLInx ChenyuLInx requested review from MichelleArk and stu-k April 19, 2023 22:48
Copy link
Contributor

@iknox-fa iknox-fa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ChenyuLInx ChenyuLInx merged commit b2418b0 into main Apr 20, 2023
@ChenyuLInx ChenyuLInx deleted the cl/targe_path_param branch April 20, 2023 15:02
@MichelleArk
Copy link
Contributor

@ChenyuLInx - does this need a backport to 1.5?

@MichelleArk
Copy link
Contributor

Confirmed this does need a backport offline 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-2439] [Bug] dbt source freshness'output(_dir) not using target-path specified in dbt_project.yml
4 participants