Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --target-path to snapshot command #7419

Merged

Conversation

dwreeves
Copy link
Contributor

@dwreeves dwreeves commented Apr 20, 2023

resolves #7418

Description

dbt snapshot uses the target path (since it runs a subclass of RunTask), but does not contain the option to specify it. This PR adds --target-path as a valid option for dbt snaphot.

Checklist

@dwreeves dwreeves requested a review from a team as a code owner April 20, 2023 14:46
@dwreeves dwreeves requested review from nssalian and aranke April 20, 2023 14:46
@cla-bot
Copy link

cla-bot bot commented Apr 20, 2023

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR.

CLA has not been signed by users: @dwreeves

@dwreeves
Copy link
Contributor Author

Woops. Just signed the CLA.

@dbeatty10
Copy link
Contributor

@cla-bot check

@cla-bot cla-bot bot added the cla:yes label Apr 20, 2023
@cla-bot
Copy link

cla-bot bot commented Apr 20, 2023

The cla-bot has been summoned, and re-checked this pull request!

@dbeatty10 dbeatty10 added the ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering label Apr 20, 2023
@dwreeves
Copy link
Contributor Author

@dbeatty10 Thanks for getting to this. Do you think this can be available in time for the dbt 1.5.0 release? 😅

Copy link
Member

@aranke aranke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dbeatty10
Copy link
Contributor

Do you think this can be available in time for the dbt 1.5.0 release? 😅

@dwreeves Thanks to your early testing and contribution, this is on track to being included in the 1.5.0 release 🏆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-2443] [Regression] dbt snapshot command uses target path, but does not have a CLI option to specify it.
4 participants