Allow missing profiles.yml for dbt deps and dbt init
#7546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbeatty10
requested review from
aranke and
davidbloss
and removed request for
a team
|
@jtcohen6 I think we'll want the 1.5 backport label added to this. |
|
@dbeatty10 Agreed! To provide a little window into my methods: The label needs to be added after the PR is merged in order to trigger the GH workflow, but I like to add it before the PR is merged, as a reminder & a form of bookkeeping :) |
|
Verified that the new CI checks added in 40ef3d8 will fail as reported in the regression case: 
|
|
@jtcohen6 do you know if this was backported or not? |
|
Any dates on when this fix would be released in 1.5? |
emmyoop
pushed a commit
that referenced
this pull request
May 22, 2023
* Allow missing `profiles.yml` for `dbt deps` and `dbt init` * Some commands allow the `--profiles-dir` to not exist * Remove fix to verify that CI tests work * Allow missing `profiles.yml` for `dbt deps` and `dbt init` * CI is not finding any installed adapters * Remove functional test for `dbt init`
emmyoop
pushed a commit
that referenced
this pull request
May 22, 2023
* Allow missing `profiles.yml` for `dbt deps` and `dbt init` * Some commands allow the `--profiles-dir` to not exist * Remove fix to verify that CI tests work * Allow missing `profiles.yml` for `dbt deps` and `dbt init` * CI is not finding any installed adapters * Remove functional test for `dbt init`
6 tasks
emmyoop
added a commit
that referenced
this pull request
May 22, 2023
…7677) * Allow missing `profiles.yml` for `dbt deps` and `dbt init` * Some commands allow the `--profiles-dir` to not exist * Remove fix to verify that CI tests work * Allow missing `profiles.yml` for `dbt deps` and `dbt init` * CI is not finding any installed adapters * Remove functional test for `dbt init` Co-authored-by: Doug Beatty <44704949+dbeatty10@users.noreply.github.com>
|
@abhinav-kumar-17 we don't have a precise date yet, but it will be included in the 1.5.1 dbt-core release. |
This was referenced Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #7511
Description
Options considered
We considered four different approaches:
type=click.Path(exists=False)to ignore path validationdbt depsit's own custom version of the--profiles-dirparameter that ignores path validation (similar to Option 2 above)@p.profiles_dirfromdbt depsInitial decision
The initial decision by @jtcohen6 was:
type=click.Path(exists=False)to turn off this validation for all commands.New decision
But during implementation, I discovered an alternative click option named
profiles_dir_exists_falsethat has that behavior (which was added fordbt debug), so I chose to re-use that in order to preserve validation for the rest of the subcommands.During code review, it would be easy to go back to the initial decision if we want to.
Checklist
changie newto create a changelog entry