Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove DelayedFileHandler, Backport to 1.5 #7683

Merged
merged 1 commit into from
May 23, 2023
Merged

Remove DelayedFileHandler, Backport to 1.5 #7683

merged 1 commit into from
May 23, 2023

Conversation

peterallenwebb
Copy link
Contributor

resolves #7679

Checklist

@iknox-fa @peterallenwebb
Remove DelayedFileHandler (#7661)
5b00f9e 
* remove DelayedFileHandler

* Changelog

* set_path to no-op

* more no-ops for rpc

* Clearer comments
@peterallenwebb peterallenwebb requested review from a team as code owners May 22, 2023 21:30
@peterallenwebb peterallenwebb requested a review from a team May 22, 2023 21:30
@peterallenwebb peterallenwebb requested review from a team as code owners May 22, 2023 21:30
@peterallenwebb peterallenwebb requested review from VersusFacit, aranke and emmyoop and removed request for a team May 22, 2023 21:30
@cla-bot cla-bot bot added the cla:yes label May 22, 2023
@peterallenwebb peterallenwebb changed the base branch from main to 1.5.latest May 22, 2023 21:30
@peterallenwebb peterallenwebb changed the title Paw/ct 2587 delayed file handler backport Remove DelayedFileHandler, Backport to 1.5 May 22, 2023
aranke
aranke approved these changes May 22, 2023
View reviewed changes
Copy link
Member

@aranke aranke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if tests pass

@peterallenwebb peterallenwebb merged commit b06a8eb into 1.5.latest May 23, 2023
@peterallenwebb peterallenwebb deleted the paw/ct-2587-delayed-file-handler-backport branch May 23, 2023 13:54
This was referenced Jun 14, 2023
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aranke aranke aranke approved these changes

@VersusFacit VersusFacit Awaiting requested review from VersusFacit VersusFacit was automatically assigned from dbt-labs/adapters

@emmyoop emmyoop Awaiting requested review from emmyoop emmyoop was automatically assigned from dbt-labs/core-team

Assignees
No one assigned
Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CT-2587] DelayedFileHandler is Obsolete, Should Be Removed in 1.5 and Later Versions
3 participants
@peterallenwebb @aranke @iknox-fa