[Backport 1.5.latest] Respect column quote config in model contracts
#7858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
(cherry picked from commit 83d163a)
jtcohen6
approved these changes
Jun 14, 2023
| @@ -1,10 +0,0 @@ | |||
| {% macro get_column_names() %} | |||
There was a problem hiding this comment.
Between the v1.5.0 and next v1.5.x patch release: A Postgres user could have called this macro by name (get_column_names), and it will no longer work because now we're defining a default and dispatching it. I'm not worried about the likelihood of that happening (this is an internal & undocumented macro), just mentioning as a thing that theoretically could happen
|
I'm going to merge this in, and then rekick CI on the adapter PRs: |
This was referenced Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 83d163a from #7537.