Fix issues around new get_catalog_by_relations macro #8856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
2 tasks
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #8856 +/- ##
==========================================
+ Coverage 86.31% 86.44% +0.13%
==========================================
Files 177 177
Lines 26385 26405 +20
==========================================
+ Hits 22775 22827 +52
+ Misses 3610 3578 -32
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
gshank
approved these changes
Oct 25, 2023
Closed
4 tasks
|
I think we might have introduced a pre-regression with this PR. See the details here: dbt-labs/dbt-snowflake#816. |
peterallenwebb
added a commit
that referenced
this pull request
Oct 31, 2023
* Fix issues around new get_catalog_by_relations macro * Add changelog entry * Fix unit test. * Additional unit testing
peterallenwebb
added a commit
that referenced
this pull request
Oct 31, 2023
* Fix issues around new get_catalog_by_relations macro (#8856) * Fix issues around new get_catalog_by_relations macro * Add changelog entry * Fix unit test. * Additional unit testing * Fix cased comparison in catalog-retrieval function (#8940) * Fix cased comparison in catalog-retrieval function. * Fix cased comparison in catalog-retrieval function.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #8846
Problem
An optional parameter was added to BaseAdapter.get_catalog() in 1.7.0rc1, which was unfortunately overridden by databricks, and may also be overridden in other adapter implementations.
Solution
This changeset reverts the function to its original signature, and adds a new function called BaseAdapter.get_filtered_catalog(). It also reworks the
docs generatecode which had relied previously relied on the new parameter.Significantly, the filtering is now performed against a set of BaseRelation objects passed to the adapter, instead of a set of nodes. This reduces the number of concepts that leak into the adapter, which should not need to "know" about the dag or nodes.
Checklist