Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cased comparison in catalog-retrieval function #8940

Merged
merged 2 commits into from
Oct 30, 2023

Conversation

peterallenwebb
Copy link
Contributor

@peterallenwebb peterallenwebb commented Oct 30, 2023

resolves #8939

Problem

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@cla-bot cla-bot bot added the cla:yes label Oct 30, 2023
@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a2a7b7d) 86.50% compared to head (bb27a8f) 86.49%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8940      +/-   ##
==========================================
- Coverage   86.50%   86.49%   -0.01%     
==========================================
  Files         177      177              
  Lines       26405    26405              
==========================================
- Hits        22841    22839       -2     
- Misses       3564     3566       +2     
Flag Coverage Δ
integration 83.35% <100.00%> (-0.01%) ⬇️
unit 64.80% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
core/dbt/adapters/base/impl.py 82.85% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikealfare
Copy link
Contributor

Running dbt-snowflake integration tests against this PR: https://github.com/dbt-labs/dbt-snowflake/actions/runs/6694532138

@mikealfare
Copy link
Contributor

Running dbt-snowflake integration tests against this PR: https://github.com/dbt-labs/dbt-snowflake/actions/runs/6694532138

These tests passed, it looks like this fixes the issue.

@mikealfare mikealfare marked this pull request as ready for review October 30, 2023 15:20
@mikealfare mikealfare requested review from a team as code owners October 30, 2023 15:20
@peterallenwebb peterallenwebb merged commit 7317de2 into main Oct 30, 2023
51 checks passed
@peterallenwebb peterallenwebb deleted the paw/filtered-catalog-casefold branch October 30, 2023 15:23
peterallenwebb added a commit that referenced this pull request Oct 31, 2023
* Fix cased comparison in catalog-retrieval function.

* Fix cased comparison in catalog-retrieval function.
peterallenwebb added a commit that referenced this pull request Oct 31, 2023
* Fix issues around new get_catalog_by_relations macro (#8856)

* Fix issues around new get_catalog_by_relations macro

* Add changelog entry

* Fix unit test.

* Additional unit testing

* Fix cased comparison in catalog-retrieval function (#8940)

* Fix cased comparison in catalog-retrieval function.

* Fix cased comparison in catalog-retrieval function.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-3287] [Bug] Fix Filtering Issue In get_filtered_catalog()
2 participants