-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DSI 0.4.0 and Saved Query Exports #8950
DSI 0.4.0 and Saved Query Exports #8950
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #8950 +/- ##
==========================================
- Coverage 86.50% 86.46% -0.04%
==========================================
Files 177 179 +2
Lines 26439 26505 +66
==========================================
+ Hits 22870 22917 +47
- Misses 3569 3588 +19
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
29b662e
to
bb5fa88
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, where are we defining using DSI 0.4.x?
My PR probably needed to be updated if this goes in first, or the other way around
In dbt-labs/dbt-semantic-interfaces#186 we renamed `group_bys` to `group_by` in DSI (which went out in DSI 0.4.0). The original `group_bys` naming was a typo. This fixes that. This is a non-breaking change from the core perspective because saved queries are being introduced in 1.7.0, which has not been cut yet.
This is useful because moving it out of `nodes.py` avoids circular imports.
…y_params` object
The protocol uses `schema_name` because on the DSI side `schema` causes an error when in use with pydantic classes. However we want the user to specify `schema`. This allows for that.
Rebasing off of main to resolve conflicts |
38226ce
to
e30a837
Compare
We define the version in 'core/setup.py' |
Opened a new issue in dbt-labs/docs.getdbt.com: dbt-labs/docs.getdbt.com#4381 |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.7.latest 1.7.latest
# Navigate to the new working tree
cd .worktrees/backport-1.7.latest
# Create a new branch
git switch --create backport-8950-to-1.7.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ac972948b84e3280aa5831c5a32555521714efda
# Push it to GitHub
git push --set-upstream origin backport-8950-to-1.7.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.7.latest Then, create a pull request where the |
(cherry picked from commit ac97294)
resolves #8892
Problem
dbt-semantic-interfaces recently released 0.4.0. We want to support this for 1.7.0 of dbt-core. dbt-semantic-interfaces 0.4.0 has a few changes from 0.3.0
where
,group_by
, andmetrics
are now nested under thequery_params
property on aSavedQuery
SavedQuery
now has a concept ofexports
Solution
Begin supporting the changes.
Other things to flag
In 0.4.0 the names of metrics begin being validated by dbt-semantic-interfaces. This was always supposed to be happening, but wasn't 😬 This might break for some people. To be clear it was likely breaking in the semantic layer anyways. This just ensures that the issue is caught at parse time rather than query time.
Checklist