Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 1.7.latest] DSI 0.4.0 and Saved Query Exports #8972

Closed
wants to merge 1 commit into from

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Nov 1, 2023

Backport ac97294 from #8950.

@github-actions github-actions bot requested review from a team as code owners November 1, 2023 16:11
@github-actions github-actions bot requested review from ashnm and emmyoop and removed request for a team November 1, 2023 16:11
@cla-bot cla-bot bot added the cla:yes label Nov 1, 2023
Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Attention: 25 lines in your changes are missing coverage. Please review.

Comparison is base (333d793) 86.47% compared to head (2100256) 64.80%.

Additional details and impacted files
@@               Coverage Diff               @@
##           1.7.latest    #8972       +/-   ##
===============================================
- Coverage       86.47%   64.80%   -21.67%     
===============================================
  Files             177      179        +2     
  Lines           26439    26505       +66     
===============================================
- Hits            22862    17177     -5685     
- Misses           3577     9328     +5751     
Flag Coverage Δ
integration ?
unit 64.80% <72.52%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
core/dbt/contracts/graph/unparsed.py 88.11% <100.00%> (-5.88%) ⬇️
core/dbt/parser/manifest.py 50.17% <ø> (-42.12%) ⬇️
core/setup.py 0.00% <ø> (ø)
core/dbt/contracts/graph/semantic_layer_common.py 94.11% <94.11%> (ø)
core/dbt/parser/schema_renderer.py 82.97% <0.00%> (-12.77%) ⬇️
core/dbt/contracts/graph/saved_queries.py 83.33% <83.33%> (ø)
core/dbt/parser/schema_yaml_readers.py 0.00% <0.00%> (-92.51%) ⬇️
core/dbt/contracts/graph/nodes.py 77.57% <44.44%> (-16.64%) ⬇️

... and 114 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@QMalcolm QMalcolm closed this Nov 1, 2023
@QMalcolm
Copy link
Contributor

QMalcolm commented Nov 1, 2023

Closed in favor of #8973

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants