-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "revert python version for docker images" #9687
Conversation
This reverts commit f485c13.
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9687 +/- ##
==========================================
+ Coverage 88.06% 88.09% +0.03%
==========================================
Files 180 180
Lines 22546 22546
==========================================
+ Hits 19856 19863 +7
+ Misses 2690 2683 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me if we are able to build correctly again. @dbeatty10
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. If it's not obvious, this will only bump it for dbt-core (all versions) and dbt-postgres <=1.7. We are doing work so that every adapter maintains their own Dockerfile. Only dbt-snowflake's changes are currently merged.
@emmyoop is there a tasklist that tracks the progress of this across adapters, by any chance? |
@dbeatty10 this is not tracked anywhere I am aware of. However, the inflight PRs have a suggestion to bump to python 3.11 and I opened dbt-labs/dbt-snowflake#984 since the changes are already merged in snowflake. |
resolves: #9491
Reverts #8445
🎩
some basic testing: