Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "revert python version for docker images" #9687

Merged
merged 4 commits into from
Apr 17, 2024

Conversation

MichelleArk
Copy link
Contributor

@MichelleArk MichelleArk commented Feb 27, 2024

resolves: #9491

Reverts #8445

🎩
some basic testing:

❯ docker build --no-cache --tag python-311  .
[+] Building 48.2s (10/10) FINISHED
 => [internal] load build definition from Dockerfile                     0.0s
 => => transferring dockerfile: 37B                                      0.0s
 => [internal] load .dockerignore                                        0.0s
 => => transferring context: 2B                                          0.0s
 => [internal] load metadata for docker.io/library/python:3.11.2-slim-b  0.1s
 => CACHED [base 1/3] FROM docker.io/library/python:3.11.2-slim-bullsey  0.0s
 => [base 2/3] RUN apt-get update   && apt-get dist-upgrade -y   && ap  28.3s
 => [base 3/3] RUN python -m pip install --upgrade "pip==24.0" "setupto  3.6s
 => [dbt-core 1/2] WORKDIR /usr/app/dbt/                                 0.0s
 => [dbt-core 2/2] RUN python -m pip install --no-cache-dir "dbt-core   13.1s
 => [dbt-third-party 1/1] RUN if [ "$dbt_third_party" ]; then         p  0.3s
 => exporting to image                                                   2.5s
 => => exporting layers                                                  2.5s
 => => writing image sha256:87837cb6e1da8528ed629bd5ad8d74b43646fbfcb83  0.0s
 => => naming to docker.io/library/python-311                            0.0s

Use 'docker scan' to run Snyk tests against images to find vulnerabilities and learn how to fix them
❯ docker run python-311:latest --version
Core:
  - installed: 1.8.0-b2
  - latest:    1.7.12   - Ahead of latest version!

Plugins:

@cla-bot cla-bot bot added the cla:yes label Feb 27, 2024
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

Copy link

codecov bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.09%. Comparing base (4c1d0e9) to head (3ab8783).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9687      +/-   ##
==========================================
+ Coverage   88.06%   88.09%   +0.03%     
==========================================
  Files         180      180              
  Lines       22546    22546              
==========================================
+ Hits        19856    19863       +7     
+ Misses       2690     2683       -7     
Flag Coverage Δ
integration 85.48% <ø> (+0.10%) ⬆️
unit 62.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MichelleArk MichelleArk marked this pull request as ready for review February 27, 2024 19:21
@MichelleArk MichelleArk requested a review from a team as a code owner February 27, 2024 19:21
Copy link
Contributor

@McKnight-42 McKnight-42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me if we are able to build correctly again. @dbeatty10

Copy link
Member

@emmyoop emmyoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. If it's not obvious, this will only bump it for dbt-core (all versions) and dbt-postgres <=1.7. We are doing work so that every adapter maintains their own Dockerfile. Only dbt-snowflake's changes are currently merged.

@MichelleArk MichelleArk merged commit fe28d9e into main Apr 17, 2024
62 checks passed
@MichelleArk MichelleArk deleted the revert-8445-mcknight/revert_7196_and_6424 branch April 17, 2024 14:37
@dbeatty10
Copy link
Contributor

Looks good to me. If it's not obvious, this will only bump it for dbt-core (all versions) and dbt-postgres <=1.7. We are doing work so that every adapter maintains their own Dockerfile. Only dbt-snowflake's changes are currently merged.

@emmyoop is there a tasklist that tracks the progress of this across adapters, by any chance?

@emmyoop
Copy link
Member

emmyoop commented Apr 24, 2024

@dbeatty10 this is not tracked anywhere I am aware of. However, the inflight PRs have a suggestion to bump to python 3.11 and I opened dbt-labs/dbt-snowflake#984 since the changes are already merged in snowflake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade Dockerfile to 3.11
4 participants