Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize the adapter for core debug changes. #478

Merged
merged 2 commits into from
Jun 7, 2023

Conversation

VersusFacit
Copy link
Contributor

@VersusFacit VersusFacit commented Jun 4, 2023

PR to bring adapter in parity with this core PR.

Now will use the redshift adapter query and will show all credential lines in _connection_keys.

Feedback Requested

In the connection keys, flag any that are sensitive and should not be shown to users in plaintext

Checklist

@VersusFacit VersusFacit requested a review from a team as a code owner June 4, 2023 11:15
@VersusFacit VersusFacit self-assigned this Jun 4, 2023
@VersusFacit VersusFacit requested a review from mikealfare June 4, 2023 11:15
@cla-bot cla-bot bot added the cla:yes label Jun 4, 2023
@VersusFacit VersusFacit merged commit 8f71a52 into main Jun 7, 2023
@VersusFacit VersusFacit deleted the ADAP-496/add_test_connection_mode_to_debug branch June 7, 2023 16:57
abbywh pushed a commit to abbywh/dbt-redshift that referenced this pull request Oct 11, 2023
Co-authored-by: Mila Page <versusfacit@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants