Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize the adapter for core debug changes. #478

Merged
merged 2 commits into from
Jun 7, 2023
Merged

Standardize the adapter for core debug changes. #478

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3fd2d6c
Standardize the adapter for core debug changes.
VersusFacit Jun 4, 2023
7ba2b2a
Merge branch 'main' into ADAP-496/add_test_connection_mode_to_debug
VersusFacit Jun 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changes/unreleased/Features-20230604-041410.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
kind: Features
body: Standardize the _connection_keys and debug_query for `dbt debug`.
time: 2023-06-04T04:14:10.191263-07:00
custom:
Author: versusfacit
Issue: PR754
14 changes: 12 additions & 2 deletions dbt/adapters/redshift/connections.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,15 +162,25 @@ def type(self):
def _connection_keys(self):
return (
"host",
"port",
"user",
"port",
"database",
"schema",
"method",
"cluster_id",
"iam_profile",
"schema",
"sslmode",
"region",
"sslmode",
"region",
"iam_profile",
"autocreate",
"db_groups",
"ra3_node",
"connect_timeout",
"role",
"retries",
"autocommit",
)

@property
Expand Down
4 changes: 4 additions & 0 deletions dbt/adapters/redshift/impl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,3 +163,7 @@ def default_python_submission_method(self) -> str:

def generate_python_submission_response(self, submission_result: Any) -> AdapterResponse:
return super().generate_python_submission_response(submission_result)

def debug_query(self):
"""Override for DebugTask method"""
self.execute("select 1 as id")