Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

need col alias and flexible limit 0 clause #421

Closed
wants to merge 1 commit into from

Conversation

dataders
Copy link
Contributor

This is a:

  • bug fix PR with no breaking changes — please ensure the base branch is master
  • new functionality — please ensure the base branch is the latest dev/ branch
  • a breaking change — please ensure the base branch is the latest dev/ branch

Description & motivation

Changes to allow tsql-utils to upgrade to dbt-utils>=0.7.0

Checklist

  • I have verified that these changes work locally on the following warehouses (Note: it's okay if you do not have access to all warehouses, this helps us understand what has been covered)
    • BigQuery
    • Postgres
    • Redshift
    • Snowflake
  • I have "dispatched" any new macro(s) so non-core adapters can also use them (e.g. the star() source)
  • I have updated the README.md (if applicable)
  • I have added tests & descriptions to my models (and macros if applicable)
  • I have added an entry to CHANGELOG.md

@joellabes
Copy link
Contributor

Hey @swanderz, good catch! When this comes out of draft, happy to merge it 👍

@joellabes
Copy link
Contributor

Looks like a dupe of #437

@joellabes joellabes closed this Nov 9, 2021
@dataders
Copy link
Contributor Author

dataders commented Nov 9, 2021

uh-oh @joellabes looks like September Anders knew more than November Anders. I need to column alias on the else clause too. shall I open another PR?

@joellabes
Copy link
Contributor

Nah it's all good! I think the column alias was a red herring. it'd only be an issue if we were trying to --store-failures because then unnamed columns break (#430)

@dataders
Copy link
Contributor Author

dataders commented Nov 9, 2021

Nah it's all good! I think the column alias was a red herring. it'd only be an issue if we were trying to --store-failures because then unnamed columns break (#430)

what if I did something very hacky in dbt-sqlserver where a table is always created, but it's dropped after the test runs by default?

@joellabes
Copy link
Contributor

Then we'd have a problem 😬 I'll fix it myself, don't worry about the overhead of a PR

@joellabes
Copy link
Contributor

image

Fixed here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants