Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing an issue where the mutually exclusive range test doesn't work … #430

Conversation

codigo-ergo-sum
Copy link
Contributor

@codigo-ergo-sum codigo-ergo-sum commented Oct 20, 2021

…with store failures with a multi-column concatenated partition by clause. As per: #423

This is a:

  • bug fix PR with no breaking changes — please ensure the base branch is master
  • new functionality — please ensure the base branch is the latest dev/ branch
  • a breaking change — please ensure the base branch is the latest dev/ branch

Description & motivation

Checklist

  • I have verified that these changes work locally on the following warehouses (Note: it's okay if you do not have access to all warehouses, this helps us understand what has been covered)
    • BigQuery
    • Postgres
    • Redshift
    • Snowflake
  • I have "dispatched" any new macro(s) so non-core adapters can also use them (e.g. the star() source)
  • I have updated the README.md (if applicable)
  • I have added tests & descriptions to my models (and macros if applicable)
  • I have added an entry to CHANGELOG.md

@joellabes
Copy link
Contributor

Lovely! Thanks @codigo-ergo-sum.

As discussed on the original issue, this could be a breaking change for others who are already using --store-failures so we'll pop this out in 0.8 and include that warning in the changelog.

@joellabes joellabes self-requested a review October 21, 2021 03:20
@joellabes joellabes changed the base branch from main to next/minor November 9, 2021 04:53
@joellabes joellabes merged commit d8cf447 into dbt-labs:next/minor Nov 9, 2021
@joellabes
Copy link
Contributor

Thanks for your contribution @codigo-ergo-sum!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants