Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pull_request_template.md #438

Merged
merged 2 commits into from
Nov 9, 2021
Merged

Conversation

dataders
Copy link
Contributor

@dataders dataders commented Nov 8, 2021

This is a:

  • bug fix PR with no breaking changes — please ensure the base branch is master
  • new functionality — please ensure the base branch is the latest dev/ branch
  • a breaking change — please ensure the base branch is the latest dev/ branch

Description & motivation

Inspired by #437

There should probably be more guidelines to allow for non core adapters to stay up-to-date with dbt-utils without having to make numerous PRs ahead of each release.

Checklist

  • I have verified that these changes work locally on the following warehouses (Note: it's okay if you do not have access to all warehouses, this helps us understand what has been covered)
    • BigQuery
    • Postgres
    • Redshift
    • Snowflake
  • I have "dispatched" any new macro(s) so non-core adapters can also use them (e.g. the star() source)
  • I have updated the README.md (if applicable)
  • I have added tests & descriptions to my models (and macros if applicable)
  • I have added an entry to CHANGELOG.md

Copy link
Contributor

@joellabes joellabes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this 😍 thank you!

@joellabes joellabes merged commit 4a0a81a into dbt-labs:main Nov 9, 2021
joellabes pushed a commit that referenced this pull request Nov 9, 2021
#430)

* Fixing an issue where the mutually exclusive range test doesn't work with store failures with a multi-column concatenated partition by clause. As per: #423

* Bumping dbt version to take into account CircleCI already being upgrade to dbt 1.0b as per Joel Labes

* Further tweak to version number checks to try to fix CircleCI

* Update pull_request_template.md (#438)

* Update pull_request_template.md

* Update .github/pull_request_template.md

* Add 0.8.0 changelog block

* Add changelog for mutually excl ranges change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants