Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use is_relational check for schema caching #3716

Merged
merged 3 commits into from
Aug 12, 2021
Merged

Use is_relational check for schema caching #3716

merged 3 commits into from
Aug 12, 2021

Conversation

jtcohen6
Copy link
Contributor

@jtcohen6 jtcohen6 commented Aug 10, 2021 •
edited
Loading

resolves #3715 (check out that issue for a full description)

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR — good enough that existing tests pass? ✅
  • I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

@cla-bot cla-bot bot added the cla:yes label Aug 10, 2021
@jtcohen6 jtcohen6 temporarily deployed to Postgres August 10, 2021 12:51 Inactive
@jtcohen6 jtcohen6 temporarily deployed to Redshift August 10, 2021 12:51 Inactive
@jtcohen6 jtcohen6 temporarily deployed to Redshift August 10, 2021 12:51 Inactive
@jtcohen6 jtcohen6 temporarily deployed to Bigquery August 10, 2021 12:51 Inactive
@jtcohen6 jtcohen6 temporarily deployed to Bigquery August 10, 2021 12:51 Inactive
@jtcohen6 jtcohen6 temporarily deployed to Snowflake August 10, 2021 12:51 Inactive
@jtcohen6 jtcohen6 temporarily deployed to Snowflake August 10, 2021 12:51 Inactive
@jtcohen6 jtcohen6 temporarily deployed to Postgres August 10, 2021 12:54 Inactive
@jtcohen6 jtcohen6 temporarily deployed to Bigquery August 10, 2021 12:54 Inactive
@jtcohen6 jtcohen6 temporarily deployed to Bigquery August 10, 2021 12:54 Inactive
@jtcohen6 jtcohen6 temporarily deployed to Redshift August 10, 2021 12:54 Inactive
@jtcohen6 jtcohen6 temporarily deployed to Redshift August 10, 2021 12:54 Inactive
@jtcohen6 jtcohen6 temporarily deployed to Snowflake August 10, 2021 12:54 Inactive
@jtcohen6 jtcohen6 temporarily deployed to Snowflake August 10, 2021 12:54 Inactive
@jtcohen6 jtcohen6 marked this pull request as ready for review August 11, 2021 12:54
@jtcohen6 jtcohen6 requested review from a team, gshank and kwigley and removed request for a team August 11, 2021 12:54
@jtcohen6 jtcohen6 mentioned this pull request Aug 12, 2021
Closed
gshank
gshank approved these changes Aug 12, 2021
View reviewed changes
Copy link
Contributor

@gshank gshank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@jtcohen6 jtcohen6 temporarily deployed to Postgres August 12, 2021 21:58 Inactive
@jtcohen6 jtcohen6 temporarily deployed to Snowflake August 12, 2021 21:58 Inactive
@jtcohen6 jtcohen6 temporarily deployed to Snowflake August 12, 2021 21:58 Inactive
@jtcohen6 jtcohen6 temporarily deployed to Redshift August 12, 2021 21:58 Inactive
@jtcohen6 jtcohen6 temporarily deployed to Redshift August 12, 2021 21:58 Inactive
@jtcohen6 jtcohen6 temporarily deployed to Bigquery August 12, 2021 21:58 Inactive
@jtcohen6 jtcohen6 temporarily deployed to Bigquery August 12, 2021 21:58 Inactive
@jtcohen6 jtcohen6 merged commit b633adb into develop Aug 12, 2021
@jtcohen6 jtcohen6 deleted the fix/test-schema-caching branch August 12, 2021 22:18
jtcohen6 added a commit that referenced this pull request Aug 12, 2021
@jtcohen6
Use is_relational check for schema caching (#3716)
cc81a44 
* Use is_relational check for schema caching

* Fix flake8

* Update changelog
jtcohen6 added a commit that referenced this pull request Aug 13, 2021
@jtcohen6
Use is_relational check for schema caching (#3716) (#3737)
35150f9 
* Use is_relational check for schema caching

* Fix flake8

* Update changelog
jtcohen6 added a commit that referenced this pull request Aug 25, 2021
@jtcohen6
Use is_relational check for schema caching (#3716)
75baf6f 
* Use is_relational check for schema caching

* Fix flake8

* Update changelog
kwigley pushed a commit that referenced this pull request Aug 25, 2021
@jtcohen6
Use is_relational check for schema caching (#3716)
57d0e21 
* Use is_relational check for schema caching

* Fix flake8

* Update changelog
jtcohen6 added a commit that referenced this pull request Aug 26, 2021
@jtcohen6
Use is_relational check for schema caching (#3716) (#3809)
3cd8711 
* Use is_relational check for schema caching

* Fix flake8

* Update changelog
TeddyCr pushed a commit to TeddyCr/dbt that referenced this pull request Sep 9, 2021
@jtcohen6 @TeddyCr
Use is_relational check for schema caching (dbt-labs#3716)
2810ea8 
* Use is_relational check for schema caching

* Fix flake8

* Update changelog
@jtcohen6 jtcohen6 mentioned this pull request Sep 18, 2021
Closed
@jtcohen6 jtcohen6 mentioned this pull request Oct 14, 2021
Closed
1 task
iknox-fa pushed a commit that referenced this pull request Feb 8, 2022
@jtcohen6 @iknox-fa
Use is_relational check for schema caching (#3716)
b04b7d5 
* Use is_relational check for schema caching

* Fix flake8

* Update changelog

automatic commit by git-black, original commits:
  b633adb
  f80a759
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwigley kwigley kwigley approved these changes

@gshank gshank gshank approved these changes

Assignees
No one assigned
Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Avoid caching schemas for tests when store_failures is not enabled
3 participants
@jtcohen6 @gshank @kwigley