Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add callout for net new snapshots #6521

Merged
merged 43 commits into from
Dec 4, 2024
Merged

add callout for net new snapshots #6521

merged 43 commits into from
Dec 4, 2024

Conversation

mirnawong1
Copy link
Contributor

@mirnawong1 mirnawong1 commented Nov 21, 2024

Adding a callout to snapshot config page to clarify the new yaml config for net new snapshots. exisitng config snapshots can continue using config block, however added guidance on what to do if they want to migrate to new yaml spec.

Resolves #6374


🚀 Deployment available! Here are the direct links to the updated files:

@mirnawong1 mirnawong1 requested a review from a team as a code owner November 21, 2024 22:13
Copy link

vercel bot commented Nov 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Dec 4, 2024 9:38am

@github-actions github-actions bot added content Improvements or additions to content size: small This change will take 1 to 2 days to address Docs team Authored by the Docs team @dbt Labs labels Nov 21, 2024
Co-authored-by: Grace Goheen <53586774+graciegoheen@users.noreply.github.com>
Copy link
Collaborator

@graciegoheen graciegoheen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the original issue Doug opened was about new snapshots configs (like dbt_valid_to_current and snapshot_meta_column_names) not the "new YAML" spec - can we adjust this PR accordingly?

@mirnawong1
Copy link
Contributor Author

I think the original issue Doug opened was about new snapshots configs (like dbt_valid_to_current and snapshot_meta_column_names) not the "new YAML" spec

thanks @graciegoheen , i did meet with @dbeatty10 last week and thought he meant the new yaml spec. will loop Doug to confirm to make sure before i make further changes.

Copy link
Contributor

@dbeatty10 dbeatty10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great @mirnawong1 ! 🤩


image

What do you think about linking to this section wherever we say "If applying them to existing snapshots, you'll need to migrate over" ?

Co-authored-by: Doug Beatty <44704949+dbeatty10@users.noreply.github.com>
Co-authored-by: Doug Beatty <44704949+dbeatty10@users.noreply.github.com>
@github-actions github-actions bot added size: medium This change will take up to a week to address and removed size: small This change will take 1 to 2 days to address labels Dec 3, 2024
Copy link
Contributor

@dbeatty10 dbeatty10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@mirnawong1 mirnawong1 enabled auto-merge December 4, 2024 09:34
@mirnawong1 mirnawong1 merged commit 5dadfb5 into current Dec 4, 2024
9 checks passed
@mirnawong1 mirnawong1 deleted the net-new-snapshots branch December 4, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: medium This change will take up to a week to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Core] - Recommend using new snapshot configurations for net-new snapshots only
4 participants