Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add callout for net new snapshots #6521
add callout for net new snapshots #6521
Changes from 26 commits
befa7b5
0697083
0ff5771
4127104
5a736c5
6746196
64d56e2
0347fd3
576af99
2532cad
472d5c0
eee70d8
02fd890
1ca7c4e
43386c6
832ef12
91c3bb9
14690e0
7e68e91
6d2a38d
38762c1
bdf2850
6a84a7f
37efd7a
7eb3bf1
2fba6cc
ad3b3bd
5d3b48f
b84f4a5
915e396
61d3792
079378f
4c2708d
5732ff5
a8760c4
7dd144d
c491818
8382836
a9d4cc5
944fb50
c19c1d8
839c99d
a475180
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 155 in website/docs/reference/snapshot-configs.md
GitHub Actions / vale
[vale] website/docs/reference/snapshot-configs.md#L155
Raw output
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check warning on line 1 in website/snippets/_snapshots-yaml-config.md
GitHub Actions / vale
[vale] website/snippets/_snapshots-yaml-config.md#L1
Raw output
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this about the YAML syntax?
I think we're getting two separate things muddied:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah ok thank you for clarifying! resovled this by having the below for snapshot specific configs and general configs:
snapshot specific configs
Starting from Versionless and Core v1.9, defining snapshots in a
.sql
file using a config block is a legacy method. You can define snapshots in YAML format using the latest snapshot-specific configurations. For new snapshots, we recommend using these latest configs. If applying them to existing snapshots, you'll need to migrate over.general configs
Starting from Versionless and Core v1.9, defining snapshots in a
.sql
file using a config block is a legacy method. You can define snapshots in YAML format using the latest configurations. You can also continue using the legacy method for existing snapshots, but we recommend migrating over to the latest YAML format for better readability and maintainability.