Dont hide output from browsersync command

[mmunz]

Is there any reason not to show the output from browser-sync?
This makes it more difficult to debug, e.g. see when files are reloaded.

[rfay]

IMO what we should do is pipe it to grep to get rid of the confusing output but keep the update notifications. IIRC this was introduced in #31 and it was introduced because people were confused by the info given about the port (telling people to hit localhost:3000)

[mmunz]

@rfay i have added a grep command to remove those misleading urls

[tyler36]

Looks good to me.

[rfay]

Can be tested with ddev get https://github.com/mmunz/ddev-browsersync/tarball/dont-hide-browsersync-output

[rfay]

It doesn't seem to work as expected, still shows the bogus URLs:

$ ddev browsersync
[Browsersync] Proxying: http://localhost
[Browsersync] Access URLs:
 ------------------------------------
    Local: http://localhost:3000
 External: http://d9.example.com:3000
 ------------------------------------
[Browsersync] Watching files...

Also, I note that the README still says

NOTE: The browsersync'd URL is HTTPS, not HTTP. ddev-router redirects traffic to HTTPS, but browsersync does not know this.

[tyler36]

@rfay I'm not seeing that.

$ ddev browsersync
Proxying browsersync on https://browsersync-demo.ddev.site:3000
[Browsersync] Proxying: http://localhost
[Browsersync] Watching files...

When I remove the | grep -v "Access URLs\|--------------------\|Local: http\|External: http"

$ ddev browsersync
Proxying browsersync on https://browsersync-demo.ddev.site:3000
[Browsersync] Proxying: http://localhost
[Browsersync] Access URLs:
 ------------------------------------------------
    Local: http://localhost:3000
 External: http://browsersync-demo.ddev.site:3000
 ------------------------------------------------
[Browsersync] Watching files...

[tyler36]

My complete browsersync file. I added TESTING to the first echo to confirm the correct file is used.

#!/bin/bash

#ddev-generated
## Description: Run browser-sync in the web container
## Usage: browsersync
## Example: "ddev browsersync"
## ExecRaw: true

echo "Proxying browsersync on ${DDEV_PRIMARY_URL}:3000 TESTING"
browser-sync start -c /var/www/html/.ddev/browser-sync.js | grep -v "Access URLs\|--------------------\|Local: http\|External: http"

ddev browsersync
Proxying browsersync on https://browsersync-demo.ddev.site:3000 TESTING
[Browsersync] Proxying: http://localhost
[Browsersync] Watching files...

DDEV: 1.21.4
OS: Ubuntu

[rfay]

I had an old browsersync global command that didn't have #ddev-generated in it, so didn't get overwritten properly on ddev get.

Now I see the expected results:

$ ddev browsersync
Proxying browsersync on https://d9.example.com:3000
[Browsersync] Proxying: http://localhost
[Browsersync] Watching files...
[Browsersync] Reloading Browsers...
[Browsersync] File event [change] : web/core/profiles/demo_umami/themes/umami/css/base.css

I kind of wonder if this custom command should be installed at the project level, and I'll take a look and see if the ddev get warned me that it was skipping it.

[rfay]

It did in fact warn me, but I wasn't looking, like most people wouldn't be.

NOT overwriting file/directory /Users/rfay/.ddev/commands/web/browsersync. The #ddev-generated signature was not found in the file, so it will not be overwritten. You can just remove the file and use ddev get again if you want it to be replaced: signature was not found in file /Users/rfay/.ddev/commands/web/browsersync

[mmunz]

I kind of wonder if this custom command should be installed at the project level, and I'll take a look and see if the ddev get warned me that it was skipping it.

Also a good point, i was wondering about this too already. The globally installed command shows up in other ddev projects where the browser-sync addon is not installed. But it does not work there of course.

[mmunz]

Thanks for the fast review and merging.

[tyler36]

I kind of wonder if this custom command should be installed at the project level, and I'll take a look and see if the ddev get warned me that it was skipping it.

Hope to get around to making a PR to move it to a project-level command.

[tyler36]

@mmunz Thanks for contributing!