-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Portuguese language updates #1099
Conversation
Thank you @philsf for the improvements to the translations!! 👐🏼 👐🏼 👐🏼 👐🏼 Can you please take a look to check I didn't make an error in the copy and pasting of the translations? |
Thank you @philsf for the quick updates!! |
@ddsjoberg sorry, but I was testing with the paired dataset, and assumed the paired_wide would work the same. I just noticed the translation DOES NOT kick in when using |
Thank you VERY MUCH for the checking. I looked into the issue and ALL translated p-value footnotes were being reset back to English. Should be updated now. Can you confirm on your end? @philsf |
This is amazing, thank you very much for this @ddsjoberg. It now does what is says on the tin. I believe all tests are correctly translated to pt, in all functions I tested. Can'th thank you enough. The sad part is: the translations made so far work, but the package is not yet fully translated bc I used the previously translated strings as a base, and added a few I usually come by in day2day - but to make a proper list of translation I would need to figure out all tests/methods/models available and include the strings in the template. I will be delighted to help add more strings in the future, but I don't think you should wait to merge what was done so far. perfect is the enemy of good (or something like that) |
@philsf please feel free to add whenever you have time! |
What changes are proposed in this pull request?
If there is an GitHub issue associated with this pull request, please provide link.
closes #1098
Checklist for PR reviewer
tbl_summary()
, was the same change implemented fortbl_svysummary()
?_pkgdown.yml
pkgdown::build_site()
. Check the R console for errors, and review the rendered website.covr::report()
. Before you run, setSys.setenv(NOT_CRAN="true")
and begin in a fresh R session without any packages loaded.usethis::use_spell_check()
runs with no spelling errors in documentationWhen the branch is ready to be merged into master:
# gtsummary (development version)
". If there is an issue associated with the pull request, reference it in parantheses at the end update (seeNEWS.md
for examples).usethis::use_version(which = "dev")
codemetar::write_codemeta()
usethis::use_spell_check()
again