Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portuguese language updates #1099

Merged
merged 4 commits into from
Jan 9, 2022
Merged

Portuguese language updates #1099

merged 4 commits into from
Jan 9, 2022

Conversation

ddsjoberg
Copy link
Owner

What changes are proposed in this pull request?

If there is an GitHub issue associated with this pull request, please provide link.

closes #1098


Checklist for PR reviewer

  • PR branch has pulled the most recent updates from master branch. Ensure the pull request branch and your local version match and both have the latest updates from the master branch.
  • If an update was made to tbl_summary(), was the same change implemented for tbl_svysummary()?
  • If a new function was added, function included in _pkgdown.yml
  • If a bug was fixed, a unit test was added for the bug check
  • Run pkgdown::build_site(). Check the R console for errors, and review the rendered website.
  • Code coverage is suitable for any new functions/features. Review coverage with covr::report(). Before you run, set Sys.setenv(NOT_CRAN="true") and begin in a fresh R session without any packages loaded.
  • R CMD Check runs without errors, warnings, and notes
  • usethis::use_spell_check() runs with no spelling errors in documentation

When the branch is ready to be merged into master:

  • Update NEWS.md with the changes from this pull request under the heading "# gtsummary (development version)". If there is an issue associated with the pull request, reference it in parantheses at the end update (see NEWS.md for examples).
  • Increment the version number using usethis::use_version(which = "dev")
  • Run codemetar::write_codemeta()
  • Run usethis::use_spell_check() again
  • Approve Pull Request
  • Merge the PR. Please use "Squash and merge".

@ddsjoberg
Copy link
Owner Author

Thank you @philsf for the improvements to the translations!! 👐🏼 👐🏼 👐🏼 👐🏼

Can you please take a look to check I didn't make an error in the copy and pasting of the translations?

@ddsjoberg ddsjoberg mentioned this pull request Jan 8, 2022
14 tasks
@ddsjoberg
Copy link
Owner Author

Thank you @philsf for the quick updates!!

@philsf
Copy link

philsf commented Jan 8, 2022

@ddsjoberg sorry, but I was testing with the paired dataset, and assumed the paired_wide would work the same. I just noticed the translation DOES NOT kick in when using mcnemar.test.wide for some reason. Is it being collected from a different source, other than the XLSX/CSV I provided?

@ddsjoberg
Copy link
Owner Author

@ddsjoberg sorry, but I was testing with the paired dataset, and assumed the paired_wide would work the same. I just noticed the translation DOES NOT kick in when using mcnemar.test.wide for some reason. Is it being collected from a different source, other than the XLSX/CSV I provided?

Thank you VERY MUCH for the checking. I looked into the issue and ALL translated p-value footnotes were being reset back to English. Should be updated now. Can you confirm on your end? @philsf

@philsf
Copy link

philsf commented Jan 9, 2022

This is amazing, thank you very much for this @ddsjoberg.

It now does what is says on the tin. I believe all tests are correctly translated to pt, in all functions I tested. Can'th thank you enough.

The sad part is: the translations made so far work, but the package is not yet fully translated bc I used the previously translated strings as a base, and added a few I usually come by in day2day - but to make a proper list of translation I would need to figure out all tests/methods/models available and include the strings in the template. I will be delighted to help add more strings in the future, but I don't think you should wait to merge what was done so far.

perfect is the enemy of good (or something like that)

@ddsjoberg
Copy link
Owner Author

@philsf please feel free to add whenever you have time!

@ddsjoberg ddsjoberg merged commit 0df50fa into main Jan 9, 2022
@ddsjoberg ddsjoberg deleted the pt_translations branch January 21, 2022 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug Report: update pt translations
2 participants