Include application specification for mix.exs #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Btw, if you could ship a new release, it would be very appropriated. |
|
Hi @deadtrickster! We are planning to ship the release candidate for Elixir soon and this will unfortunately break existing projects. Any chance that a new release could be done with it? Thank you! ❤️ |
|
yep will do soon, thanks for reminder |
|
Hi @deadtrickster, sorry for the ping, but we plan to ship Elixir v1.15-rc this week. If you have some time to ship a new release with this fix, it will be very appreciated. :) |
jeffkreeftmeijer
added a commit
to appsignal/appsignal-elixir
that referenced
this pull request
Jun 7, 2023
The ssl_verify_fun library doesn't depend on ssl, which is required since Elixir 1.15. A patch[1] has been merged, but it hasn't been released yet. Until a new version of ssl_verify_fun is released, use rebar as the dependenvy manager for ssl_verify_fun. [1]: deadtrickster/ssl_verify_fun.erl#27
jeffkreeftmeijer
added a commit
to appsignal/appsignal-elixir
that referenced
this pull request
Jun 7, 2023
The ssl_verify_fun library doesn't depend on ssl, which is required since Elixir 1.15. A patch[1] has been merged, but it hasn't been released yet. Until a new version of ssl_verify_fun is released, use rebar as the dependenvy manager for ssl_verify_fun. [1]: deadtrickster/ssl_verify_fun.erl#27
jeffkreeftmeijer
added a commit
to appsignal/appsignal-elixir
that referenced
this pull request
Jun 7, 2023
The ssl_verify_fun library doesn't depend on ssl, which is required since Elixir 1.15. A patch[1] has been merged, but it hasn't been released yet. Until a new version of ssl_verify_fun is released, use rebar as the dependenvy manager for ssl_verify_fun. [1]: deadtrickster/ssl_verify_fun.erl#27
jeffkreeftmeijer
added a commit
to appsignal/appsignal-elixir
that referenced
this pull request
Jun 8, 2023
The ssl_verify_fun library doesn't depend on ssl, which is required since Elixir 1.15. A patch[1] has been merged, but it hasn't been released yet. Until a new version of ssl_verify_fun is released, use rebar as the dependenvy manager for ssl_verify_fun. [1]: deadtrickster/ssl_verify_fun.erl#27
jeffkreeftmeijer
added a commit
to appsignal/appsignal-elixir
that referenced
this pull request
Jun 8, 2023
The ssl_verify_fun library doesn't depend on ssl, which is required since Elixir 1.15. A patch[1] has been merged, but it hasn't been released yet. Until a new version of ssl_verify_fun is released, use rebar as the dependenvy manager for ssl_verify_fun. [1]: deadtrickster/ssl_verify_fun.erl#27
jeffkreeftmeijer
added a commit
to appsignal/appsignal-elixir
that referenced
this pull request
Jun 8, 2023
The ssl_verify_fun library doesn't depend on ssl, which is required since Elixir 1.15. A patch[1] has been merged, but it hasn't been released yet. Until a new version of ssl_verify_fun is released, use rebar as the dependenvy manager for ssl_verify_fun. [1]: deadtrickster/ssl_verify_fun.erl#27
jeffkreeftmeijer
added a commit
to appsignal/appsignal-elixir
that referenced
this pull request
Jun 12, 2023
* Revert "Don't run tests on Elixir main on CI This reverts commit 6331329. Closes #815. * Use rebar as dependency manager for ssl_verify_fun The ssl_verify_fun library doesn't depend on ssl, which is required since Elixir 1.15. A patch[1] has been merged, but it hasn't been released yet. Until a new version of ssl_verify_fun is released, use rebar as the dependenvy manager for ssl_verify_fun. [1]: deadtrickster/ssl_verify_fun.erl#27 * Add Elixir 1.15.0-rc.1 to CI versions Add 1.15.0 to .semaphore/versions.rb * Require Appsignal.Agent in diagnose_test To resolve the compilation error in file test/mix/tasks/appsignal_diagnose_test.exs on Elixir 1.15, explicitly require Appsignal.Agent before referring to it. * Add decimal to dependencies Updating to Elixir 1.15 produces the following errors when running dialyzer: Error loading decimal, dependency list may be incomplete. {~c"no such file or directory", ~c"decimal.app"} Error loading decimal, dependency list may be incomplete. {~c"no such file or directory", ~c"decimal.app"} * Use Logger.warning/1 instead of warn/1 Logger.warn/1 is deprecated in favor of Logger.warning/1. This patch replaces all occurrences of the former with the latter. * Add backwards compatible logger Since Logger.warn is now deprecated, add logging functions to AppSignal.Utils that call Logger.warn on Elixir versions before 1.11, and Logger.warning for newer versions. This patch can be removed when dropping support for Elixir 1.10. * Ignore dialyzer warnings introduced in Elixir 1.15 The new dialyzer warnings show an issue in the return types of the Nif's diagnose function that can never be reached. Ignore these errors for now in order to fix the build and ship the changes needed to run CI on Elixir 1.15.
|
We're running into this at AppSignal too, where we're having to switch to rebar as the dependency manager on CI (as per elixir-lang/elixir#12653) to be able to test on Elixir 1.15 and main, but having to remove that to be able to release the package, meaning we're now split into two branches. A release of this patch would save us some time, and that would be appreciated. :) |
bettio
added a commit
to bettio/edgehog
that referenced
this pull request
Jun 15, 2023
Update x509 aswell. There is an issue with ssl_verify_fun, see also: deadtrickster/ssl_verify_fun.erl#27 . Signed-off-by: Davide Bettio <davide.bettio@secomind.com>
bettio
added a commit
to bettio/edgehog
that referenced
this pull request
Jun 15, 2023
- Update x509 aswell - There is an issue with ssl_verify_fun, see also: deadtrickster/ssl_verify_fun.erl#27 so a woraround has been used - There are some minor code formatting changes Signed-off-by: Davide Bettio <davide.bettio@secomind.com>
bettio
added a commit
to bettio/edgehog
that referenced
this pull request
Jun 15, 2023
- Update x509 aswell - There is an issue with ssl_verify_fun, see also: deadtrickster/ssl_verify_fun.erl#27 so a woraround has been used - There are some minor code formatting changes Signed-off-by: Davide Bettio <davide.bettio@secomind.com>
jeffkreeftmeijer
added a commit
to appsignal/appsignal-elixir-phoenix
that referenced
this pull request
Jun 16, 2023
Update the CI matrix based on the versions listed in appsignal-elixir's versions.rb file. Note that this does *not* include any of the Elixir release candidates, as they break the build. We're awaiting a release of ssl_verify_fun that includes deadtrickster/ssl_verify_fun.erl#27 before we can add back the new Elixir verions.
jeffkreeftmeijer
added a commit
to appsignal/appsignal-elixir-phoenix
that referenced
this pull request
Jun 16, 2023
Update the CI matrix based on the versions listed in appsignal-elixir's versions.rb file. Note that this does *not* include any of the Elixir release candidates, as they break the build. We're awaiting a release of ssl_verify_fun that includes deadtrickster/ssl_verify_fun.erl#27 before we can add back the new Elixir verions.
jeffkreeftmeijer
added a commit
to appsignal/appsignal-elixir-phoenix
that referenced
this pull request
Jun 16, 2023
Update the CI matrix based on the versions listed in appsignal-elixir's versions.rb file. Note that this does *not* include any of the Elixir release candidates, as they break the build. We're awaiting a release of ssl_verify_fun that includes deadtrickster/ssl_verify_fun.erl#27 before we can add back the new Elixir verions.
jeffkreeftmeijer
added a commit
to appsignal/appsignal-elixir-phoenix
that referenced
this pull request
Jun 16, 2023
* Use Logger.warning/1 instead of Logger.warn/1 Drop support for elxir 1.9 and 1.10 so we can move from warn to warning log level. * Use Utils.warning/1 instead of Logger.warning/1 Update the minimal version of the appsignal dependenvy to 2.7.4, which is the version that introduces the backwards compatible logging functions in Appsignal.Utils. Then, use Appsignal.Utils.warning/1 in Appsignal.Phoenix.View and Appsignal.Phoenix.EventHandler to support Elixir 1.10 through 1.15. * Regenerate CI matrix Update the CI matrix based on the versions listed in appsignal-elixir's versions.rb file. Note that this does *not* include any of the Elixir release candidates, as they break the build. We're awaiting a release of ssl_verify_fun that includes deadtrickster/ssl_verify_fun.erl#27 before we can add back the new Elixir verions. * Add changeset to explain changes for patch version "Fix Logger deprecation warnings on Elixir 1.15" * Update appsignal_plug to fix Elixir 1.15 warnings AppSignal for Plug 2.0.14 uses the backwards compatible logger. Depend on that version or higher to solve issues in Phoenix app that originate in the Plug library. --------- Co-authored-by: Mark Madsen <mm@idyll.io>
|
Hi @deadtrickster! Elixir 1.15 was released yesterday, so I bet a lot more people are gonna run into this 😩 Anything we can do to help move this along? 😊 |
jeffkreeftmeijer
added a commit
to appsignal/appsignal-elixir
that referenced
this pull request
Jun 20, 2023
The ssl_verify_fun library doesn't depend on ssl, which is required since Elixir 1.15. A patch[1] has been merged, but it hasn't been released yet. Until a new version of ssl_verify_fun is released, use rebar as the dependenvy manager for ssl_verify_fun. [1]: deadtrickster/ssl_verify_fun.erl#27
jeffkreeftmeijer
added a commit
to appsignal/appsignal-elixir
that referenced
this pull request
Jun 20, 2023
The ssl_verify_fun library doesn't depend on ssl, which is required since Elixir 1.15. A patch[1] has been merged, but it hasn't been released yet. Until a new version of ssl_verify_fun is released, use rebar as the dependenvy manager for ssl_verify_fun. [1]: deadtrickster/ssl_verify_fun.erl#27
|
I'm sorry it took that long. |
|
also published the hex package |
jeffkreeftmeijer
added a commit
to appsignal/appsignal-elixir
that referenced
this pull request
Jun 21, 2023
* Revert "Don't run tests on Elixir main on CI This reverts commit 6331329. Closes #815. * Use rebar as dependency manager for ssl_verify_fun The ssl_verify_fun library doesn't depend on ssl, which is required since Elixir 1.15. A patch[1] has been merged, but it hasn't been released yet. Until a new version of ssl_verify_fun is released, use rebar as the dependenvy manager for ssl_verify_fun. [1]: deadtrickster/ssl_verify_fun.erl#27 * Add Elixir 1.15.0 to CI versions Add 1.15.0 to .semaphore/versions.rb * Run linters and dialyzer on Elixir 1.15 Instead of running formatters and dialyzer on Elixir main, which is prone to change, run these on the latest proper release. * Format argument_cleaner_test to use ~c sigil Since Elixir 1.15, the formatter uses the ~c sigil over single quotes for char lists. * Remove ssl_verify_fun override A new version of ssl_verify_fun was released (1.1.7), which doesn't require rebar to be used as a dependency manager anymore. * Update diagnose test submodule Update the diagnose tests submodule to update ssl_verify_fun to a new version that works on Elixir 1.15 and up.
10 tasks
gf3
added a commit
to gf3/ueberauth
that referenced
this pull request
Aug 17, 2023
grzuy
added a commit
to mimiquate/lemon_ex
that referenced
this pull request
Aug 23, 2023
1 task
farktronix
added a commit
to farktronix/elixir-daemon
that referenced
this pull request
Oct 9, 2023
This required bumping the version of hackney so that it would pick up the latest version of ssl_verify_fun to work around deadtrickster/ssl_verify_fun.erl#27
farktronix
added a commit
to farktronix/elixir-daemon
that referenced
this pull request
Oct 12, 2023
This required bumping the version of hackney so that it would pick up the latest version of ssl_verify_fun to work around deadtrickster/ssl_verify_fun.erl#27
IvanIvanoff
added a commit
to IvanIvanoff/telemetry_metrics_prometheus_core
that referenced
this pull request
Jan 16, 2024
gf3
added a commit
to gf3/cocktail
that referenced
this pull request
Feb 14, 2024
gf3
added a commit
to gf3/ueberauth
that referenced
this pull request
Feb 26, 2024
yordis
pushed a commit
to ueberauth/ueberauth
that referenced
this pull request
Feb 27, 2024
* chore: update excoveralls dependency to fix failing compile See: deadtrickster/ssl_verify_fun.erl#27 * fix: callback_url/1 uses conn.port by default * fix: re-add port normalization ℅ @wkirschbaum * fix: remove invalid test case
sgerrand
added a commit
to sgerrand/paginator
that referenced
this pull request
Mar 14, 2024
This is required to support Elixir versions >= 1.15. See: deadtrickster/ssl_verify_fun.erl#27
sgerrand
added a commit
to sgerrand/paginator
that referenced
this pull request
Mar 14, 2024
Fixes complie errors with Elixir versions >= 1.15. See: deadtrickster/ssl_verify_fun.erl#27
sgerrand
added a commit
to sgerrand/paginator
that referenced
this pull request
Mar 14, 2024
Fixes compile errors with Elixir versions >= 1.15. See: deadtrickster/ssl_verify_fun.erl#27
2 tasks
sgerrand
added a commit
to sgerrand/paginator
that referenced
this pull request
May 29, 2024
Fixes compile errors with Elixir versions >= 1.15. See: deadtrickster/ssl_verify_fun.erl#27
sabiwara
pushed a commit
to sabiwara/waffle
that referenced
this pull request
Jun 5, 2024
Includes this fix deadtrickster/ssl_verify_fun.erl#27
mediremi
added a commit
to beanshq/timex
that referenced
this pull request
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this fix, ssl_verify_fun.erl can fail to compile
or run in Elixir, as it won't include the important :ssl
dependency.