-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mises à jour techniques (Elixir 1.15, packages Hex...) #3429
Conversation
…yxir.Output is not available)`
Updated and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: phoenix_live_view@0.18.18 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Je n'ai pas compris si on devait attendre un fix pour Dialyzer et Bypass ou si c'était ok sans.
Tu as testé cette branche en staging ?
J'ai corrigé pour Dialyzer (le fix consistait à ajouter Dialyzer sur chaque sous-app), ça fonctionne de ce côté ! Et pour Bypass c'est OK sans corriger.
Un peu mais pas très poussé ; je vais ajouter quelques mises à jour supplémentaires (des mainteneurs ont répondu à ma demande de release), puis re-pousser et voir. |
@AntoineAugusti je viens de faire un bon tour, tout semble ok ! |
type: string | ||
plt_cache_key: | ||
default: plt-v3 | ||
default: plt-v4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ça c'était fait pour essayer de débugger les soucis Dialyzer, mais au final j'ai fait autrement (vois plus bas)
@@ -7,12 +7,12 @@ | |||
# - https://hexdocs.pm/elixir/compatibility-and-deprecations.html | |||
# - https://github.com/elixir-lang/elixir/releases | |||
# - `asdf list all elixir` | |||
elixir 1.14.5-otp-24 | |||
elixir 1.15.5-otp-24 | |||
|
|||
# See: | |||
# - https://github.com/erlang/otp/releases | |||
# - https://github.com/erlang/otp/blob/master/otp_versions.table | |||
# - `asdf list all erlang` | |||
erlang 24.3.4.13 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Vous avez vu je suis gentil j'ai pas upgradé Erlang :-)
{:exvcr, "~> 0.13", only: :test}, | ||
{:mox, "~> 1.0.0", only: :test}, | ||
{:sentry, "~> 8.0"} | ||
{:sentry, "~> 8.1"}, | ||
{:dialyxir, "~> 1.2", only: [:dev, :test], runtime: false}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Le correctif Dialyzer consiste à mettre dialyxir
dans chaque sous application (apps/transport
, apps/datagouvfr
etc).
@@ -35,7 +35,7 @@ defmodule GBFS.VCubController do | |||
|> render("gbfs.json") | |||
end | |||
|
|||
@spec station_aux(Plug.Conn.t(), (() -> {:ok, map()} | {:error, binary()})) :: Plug.Conn.t() | |||
@spec station_aux(Plug.Conn.t(), (-> {:ok, map()} | {:error, binary()})) :: Plug.Conn.t() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Formattage Elixir 1.15
@@ -33,7 +33,7 @@ defmodule TransportWeb.DatasetView do | |||
@doc """ | |||
Count the number of discussions if they are available | |||
""" | |||
def count_discussions(nil), do: '-' | |||
def count_discussions(nil), do: ~c"-" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Intriguant aussi d'utiliser un charlist ici
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oui
@@ -4,7 +4,7 @@ defmodule Transport.Validators.EXJSONSchemaTest do | |||
import Mox | |||
alias Transport.Validators.EXJSONSchema | |||
|
|||
@validator_version_regex ~r/^0\.\d\.\d$/ | |||
@validator_version_regex ~r/^0\.\d+\.\d$/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Le validateur est en 0.10.x je crois.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Si ça tourne sur le serveur prochainement, alors ça me semble bon.
Voir:
Dans cette PR (à tester sur
prochainement
):Points d'attention
function Dialyxir.Output.info/1 is undefined (module Dialyxir.Output is not available)
Mises à jour restantes
Voir:
Changelogs
Logs
mix compile