olevba: prevent side effects on python lib "email" #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These 4 files contain dde-links to calc.exe and are encrypted with excel's standard password.
Output "DDE Links:" makes another "DDE-Link " prefix unnecessary and parsing of output harder.
(making pylint happier, part 1)
making pylint happy, part 2
making pylint happier, part 3
making pylint happier, part 4
making pylint happier, part 5 (final for now)
Integrate decrypt from msoffcrypto-tools
…it's not the version installed by pip
This is a start to bring back some structure into the json output. Might not be a permanent solution, need to further discuss in PR 308
Every logging call can have an optional arg type='...' which is ignored when logging to text but shows in json output. The "type" of regular logging output in json is type='msg'. Added 2 messages with different type, adjusted existing test, created 2 new ones.
This has to be present for Office OpenXML files but is not there e.g. for OpenOffice files (odt, ...). Can still analyze the file without this.
Usually, did check for xml first, so if is not zip then the message was correct. But might change and function might be called from elsewhere.
Not sure whether this copying is necessary at all...
The current version has severe performance issues when analyzing some binary xls files. Updating to the latest plugin version solves the problem.
Update plugin_biff to latest version
Unpack the values of ptgNum float literals.
…parsing, added detection of FORMULA.FILL
… and fix Python 3 support
…patching when needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #602