Update versions of C++ dependent libraries, take 2. #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kosak
approved these changes
Jun 14, 2023
devinrsmith
approved these changes
Jun 14, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, make the C++ build script more modular.
Since the C++ source code is in the deephave-core repo, this PR has some matching changes there
deephaven/deephaven-core#4000
Once this PR is merged I need to update that other PR so that the new base image is used for the PR and the PR's check can start passing.
Notes:
This is a reduced-scope version of the original PR at #59
That PR tried to update arrow to 12.0.0, which results in the cpp client hemorraging core dumps, which I don't have
time to debug right now.
This PR should also avoid building arrow shared libraries, and build less non-needed components overall to help with build times.
We avoid building any shared libraries; we are using a variation of the options for building ABSEIL that Alex was using for the R client; we also prevent installing shared objects for zlib (which otherwise gets linked dynamically)