Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update versions of C++ dependent libraries, take 2. #4000

Merged
merged 4 commits into from
Jun 15, 2023

Conversation

jcferretti
Copy link
Member

@jcferretti jcferretti commented Jun 14, 2023

Since the build script is in the base images repo, this PR need will not pass checks until we merge the required changes in the matching PR there, at which point we can update the version of the base image in this PR to point to that new one and this PR check should pass (or at least, be meaningful).

deephaven/deephaven-base-images#61

Github actions checks are expected to fail before then.

Notes:

This is a reduced-scope version of the original PR at #3982
That PR tried to update arrow to 12.0.0, which results in the cpp client hemorraging core dumps, which I don't have
time to debug right now.

kosak
kosak previously approved these changes Jun 14, 2023
@jcferretti jcferretti marked this pull request as ready for review June 15, 2023 15:07
Copy link
Member

@devinrsmith devinrsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming CMakeLists.txt change is expected, LGTM assuming CI passes.

@jcferretti jcferretti merged commit 260bc2c into deephaven:main Jun 15, 2023
10 checks passed
@jcferretti jcferretti deleted the cfs-update-cpp-deps-2 branch June 15, 2023 18:19
@github-actions github-actions bot locked and limited conversation to collaborators Jun 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants