Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test all supported versions of python #3724

Open
devinrsmith opened this issue Apr 24, 2023 · 1 comment
Open

Test all supported versions of python #3724

devinrsmith opened this issue Apr 24, 2023 · 1 comment
Assignees
Milestone

Comments

@devinrsmith
Copy link
Member

Currently, we only run unit and integration python tests with the version that comes in the base image(s) (3.10).

Ideally, we would be able to expand this to a matrix of all supported python versions.

Related #2593

@rcaudy
Copy link
Member

rcaudy commented Mar 12, 2024

Our support matrix is 3.8-3.12 right now.

@rcaudy rcaudy modified the milestones: 5. Backlog, 2. April 2024 Mar 18, 2024
devinrsmith added a commit to devinrsmith/deephaven-core that referenced this issue Mar 20, 2024
We've had a few recent issue/PRs dealing with python minimum version support: deephaven#5227, deephaven#5235, and deephaven#5271

Ultimately, we'd like a full matrix of testing support: deephaven#3724, deephaven#3725

In the more immediate term, there is a tool that I've verified is capable of catching these sorts of issues: https://github.com/netromdk/vermin. I've verified that it does catch deephaven#5227 and deephaven#5271, but does not catch deephaven#5235 (which seems like it is more of a runtime error).

This PR adds a quick CI job to verify a python minimum version of 3.8. The `# novermin` comment is necessary in a few locations where we've explicitly / manually worked around python minimum version support.
devinrsmith added a commit that referenced this issue Mar 21, 2024
We've had a few recent issue/PRs dealing with python minimum version support: #5227, #5235, and #5271

Ultimately, we'd like a full matrix of testing support: #3724, #3725

In the more immediate term, there is a tool that I've verified is capable of catching these sorts of issues: https://github.com/netromdk/vermin. I've verified that it does catch #5227 and #5271, but does not catch #5235 (which seems like it is more of a runtime error).

This PR adds a quick CI job to verify a python minimum version of 3.8. The `# novermin` comment is necessary in a few locations where we've explicitly / manually worked around python minimum version support.
@pete-petey pete-petey modified the milestones: 2. April 2024, Backlog Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants