Adds a quick CI job to verify python minimum version #5272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've had a few recent issue/PRs dealing with python minimum version support: deephaven#5227, deephaven#5235, and deephaven#5271 Ultimately, we'd like a full matrix of testing support: deephaven#3724, deephaven#3725 In the more immediate term, there is a tool that I've verified is capable of catching these sorts of issues: https://github.com/netromdk/vermin. I've verified that it does catch deephaven#5227 and deephaven#5271, but does not catch deephaven#5235 (which seems like it is more of a runtime error). This PR adds a quick CI job to verify a python minimum version of 3.8. The `# novermin` comment is necessary in a few locations where we've explicitly / manually worked around python minimum version support.
devinrsmith
added
ci
NoDocumentationNeeded
NoReleaseNotesNeeded
devinrsmith
requested review from
chipkent,
jmao-denver,
rcaudy,
jcferretti,
JamesXNelson and
mofojed
as code owners
|
I've explicitly run this against main expecting it to fail so we can see what it looks like. Once #5271 merges, I'll merge to get up-to-date with main and re-run. |
chipkent
previously approved these changes
Mar 20, 2024
rcaudy
reviewed
Mar 21, 2024
jmao-denver
reviewed
Mar 21, 2024
Comment on lines
+59
to
+61
| with: | ||
| python-version: '3.12' | ||
| cache: 'pip' |
There was a problem hiding this comment.
I wonder if we use 3.8 here, would it catch more 3.8 related compatibility issue?
There was a problem hiding this comment.
The project has this recommendation:
It is recommended to use the most recent Python version to run Vermin on projects since Python's own language parser is used to detect language features, like f-strings since Python 3.6 etc.
Unless we discover otherwise, I'd like to follow this recommendation.
jcferretti
approved these changes
Mar 21, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've had a few recent issue/PRs dealing with python minimum version support: #5227, #5235, and #5271
Ultimately, we'd like a full matrix of testing support: #3724, #3725
In the more immediate term, there is a tool that I've verified is capable of catching these sorts of issues: https://github.com/netromdk/vermin. I've verified that it does catch #5227 and #5271, but does not catch #5235 (which seems like it is more of a runtime error).
This PR adds a quick CI job to verify a python minimum version of 3.8. The
# novermincomment is necessary in a few locations where we've explicitly / manually worked around python minimum version support.