Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

java-client Should Support ColumnHeader of any Primitive Array Type #4721

Closed
nbauernfeind opened this issue Oct 25, 2023 · 4 comments · Fixed by #5494
Closed

java-client Should Support ColumnHeader of any Primitive Array Type #4721

nbauernfeind opened this issue Oct 25, 2023 · 4 comments · Fixed by #5494
Assignees
Labels

Comments

@nbauernfeind
Copy link
Member

Currently the java-client only supports byte[] in the category of primitive arrays. This was implemented by a user in #4507.

The server-side, barrage-java-client, and flight-only client, each support arrays of all primitive types. They support arbitrarily nested arrays of primitives (e.g. int[][][]).

The java-client should support all primitive array types and nested primitive arrays. See the UnsupportedOperationException from here: https://github.com/deephaven/deephaven-core/blob/main/java-client/flight/src/main/java/io/deephaven/client/impl/FieldAdapter.java#L135

@rbasralian
Copy link
Contributor

We should also support String arrays, and ideally any other serializable type.

@devinrsmith
Copy link
Member

Potentially useful to have APIs where VectorSchemaRoot is exposed.

@devinrsmith
Copy link
Member

https://arrow.apache.org/cookbook/java/create.html#array-of-list shows an example of how to create these sorts of structures with Arrow Java

devinrsmith added a commit to devinrsmith/deephaven-core that referenced this issue May 16, 2024
This is a quick pass at adding support for sending primitive typed arrays with the java client. A more thorough (and dense) recursive solution was initially created, but this was a more explicit version created for expediency.

The better solution can come at a later date. Ideally, we'd also add integration tests. In lieu of that, a new example utility that demonstrates all of the types was created.

Fixes deephaven#4721
devinrsmith added a commit that referenced this issue May 17, 2024
This is a quick pass at adding support for sending primitive typed arrays, String, and Instant[] with the java client. A more thorough (and dense) recursive solution was initially created, but this was a more explicit version created for expediency.

The better solution can come at a later date. Ideally, we'd also add integration tests. In lieu of that, a new example utility that demonstrates all of the types was created.

Fixes #4721
stanbrub pushed a commit that referenced this issue May 17, 2024
This is a quick pass at adding support for sending primitive typed arrays, String, and Instant[] with the java client. A more thorough (and dense) recursive solution was initially created, but this was a more explicit version created for expediency.

The better solution can come at a later date. Ideally, we'd also add integration tests. In lieu of that, a new example utility that demonstrates all of the types was created.

Fixes #4721
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants