Add java-client support for primitive array types #5494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a quick pass at adding support for sending primitive typed arrays with the java client. A more thorough (and dense) recursive solution was initially created, but this was a more explicit version created for expediency. The better solution can come at a later date. Ideally, we'd also add integration tests. In lieu of that, a new example utility that demonstrates all of the types was created. Fixes deephaven#4721
devinrsmith
added
NoDocumentationNeeded
java-client
ReleaseNotesNeeded
nbauernfeind
previously approved these changes
May 17, 2024
java-client/flight/src/main/java/io/deephaven/client/impl/FieldVectorAdapter.java
Outdated
Show resolved
Hide resolved
rcaudy
reviewed
May 17, 2024
nbauernfeind
approved these changes
May 17, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick pass at adding support for sending primitive typed arrays with the java client. A more thorough (and dense) recursive solution was initially created, but this was a more explicit version created for expediency.
The better solution can come at a later date. Ideally, we'd also add integration tests. In lieu of that, a new example utility that demonstrates all of the types was created.
Fixes #4721