-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update github gradle action to something well supported #5161
Comments
Given #5086, I think it makes sense to investigate the gradle action tooling around this. https://github.com/gradle/actions |
devinrsmith
added a commit
to devinrsmith/deephaven-server-docker
that referenced
this issue
Feb 27, 2024
burrunan/gradle-cache-action seems unmaintained, with the last release in August 2020. gradle/actions/setup-gradle is the officially maintained by Gradle action that has been getting a lot of work done recently. See deephaven/deephaven-core#5161
devinrsmith
added a commit
to devinrsmith/deephaven-server-docker
that referenced
this issue
Mar 20, 2024
burrunan/gradle-cache-action seems unmaintained, with the last release in August 2020. gradle/actions/setup-gradle is the officially maintained by Gradle action that has been getting a lot of work done recently. See deephaven/deephaven-core#5161
devinrsmith
added a commit
to deephaven/deephaven-server-docker
that referenced
this issue
Apr 4, 2024
burrunan/gradle-cache-action seems unmaintained, with the last release in August 2020. gradle/actions/setup-gradle is the officially maintained by Gradle action that has been getting a lot of work done recently. This also removes the build scans. We've never needed to use build scans in context with these jobs in the past. This could be changed in the future if necessary. See deephaven/deephaven-core#5161
devinrsmith
added a commit
to devinrsmith/deephaven-core
that referenced
this issue
Aug 5, 2024
This upgrades from the no longer maintained action `burrunan/gradle-cache-action` to the gradle maintained action `gradle/actions/setup-gradle`. There is a different usage pattern; with `setup-gradle`, it is invoked first during setup as opposed to at the command site. We were also using job-ids with `burrunan/gradle-cache-action` to implicitly control cache prefixes; it is not clear if we actually need to separate caches, and so (for now), the default caching behavior of `gradle/actions/setup-gradle` is used, https://github.com/gradle/actions/blob/v3.5.0/docs/setup-gradle.md#caching-build-state-between-jobs. By default, the action will read from cache, but will only write to the cache for jobs on the `main` branch. Fixes deephaven#5161
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This warning is logged on all builds now, apparently since sept of last year. The action doesn't appear to be getting new updates.
In the meantime, https://docs.gradle.org/current/userguide/github-actions.html shows that Gradle has released their own setup action, and the plain https://github.com/actions/setup-java action has had support for gradle caching as well for quite some time.
The text was updated successfully, but these errors were encountered: