Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update github gradle action to something well supported #5161

Closed
niloc132 opened this issue Feb 16, 2024 · 2 comments · Fixed by #5905
Closed

Update github gradle action to something well supported #5161

niloc132 opened this issue Feb 16, 2024 · 2 comments · Fixed by #5905
Assignees
@niloc132 @devinrsmith
Labels
bug Something isn't working build ci triage
Milestone
2. April 2024

Comments

@niloc132
Copy link
Member

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: burrunan/gradle-cache-action@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

This warning is logged on all builds now, apparently since sept of last year. The action doesn't appear to be getting new updates.

In the meantime, https://docs.gradle.org/current/userguide/github-actions.html shows that Gradle has released their own setup action, and the plain https://github.com/actions/setup-java action has had support for gradle caching as well for quite some time.
@niloc132 niloc132 added bug Something isn't working build triage ci labels Feb 16, 2024
@devinrsmith
Copy link
Member

Given #5086, I think it makes sense to investigate the gradle action tooling around this. https://github.com/gradle/actions

devinrsmith added a commit to devinrsmith/deephaven-server-docker that referenced this issue Feb 27, 2024
@devinrsmith
Migrate from gradle-cache-action to setup-gradle
922f928 
burrunan/gradle-cache-action seems unmaintained, with the last release in August 2020.

gradle/actions/setup-gradle is the officially maintained by Gradle action that has been getting a lot of work done recently.

See deephaven/deephaven-core#5161
@devinrsmith devinrsmith mentioned this issue Feb 27, 2024
Merged
devinrsmith added a commit to devinrsmith/deephaven-server-docker that referenced this issue Mar 20, 2024
@devinrsmith
Migrate from gradle-cache-action to setup-gradle
d94806f 
burrunan/gradle-cache-action seems unmaintained, with the last release in August 2020.

gradle/actions/setup-gradle is the officially maintained by Gradle action that has been getting a lot of work done recently.

See deephaven/deephaven-core#5161
devinrsmith added a commit to deephaven/deephaven-server-docker that referenced this issue Apr 4, 2024
@devinrsmith
Migrate from gradle-cache-action to setup-gradle (#82)
80e5bed 
burrunan/gradle-cache-action seems unmaintained, with the last release in August 2020.

gradle/actions/setup-gradle is the officially maintained by Gradle action that has been getting a lot of work done recently.

This also removes the build scans. We've never needed to use build scans in context with these jobs in the past. This could be changed in the future if necessary.

See deephaven/deephaven-core#5161
@devinrsmith devinrsmith added this to the 2. April 2024 milestone Apr 8, 2024
devinrsmith added a commit to devinrsmith/deephaven-core that referenced this issue Aug 5, 2024
@devinrsmith
fix: Upgrade to gradle
6a28ecf 
This upgrades from the no longer maintained action `burrunan/gradle-cache-action` to the gradle maintained action `gradle/actions/setup-gradle`. There is a different usage pattern; with `setup-gradle`, it is invoked first during setup as opposed to at the command site. We were also using job-ids with `burrunan/gradle-cache-action` to implicitly control cache prefixes; it is not clear if we actually need to separate caches, and so (for now), the default caching behavior of `gradle/actions/setup-gradle` is used, https://github.com/gradle/actions/blob/v3.5.0/docs/setup-gradle.md#caching-build-state-between-jobs. By default, the action will read from cache, but will only write to the cache for jobs on the `main` branch.

Fixes deephaven#5161
@devinrsmith devinrsmith mentioned this issue Aug 5, 2024
Merged
@devinrsmith
Copy link
Member

https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@niloc132 niloc132

@devinrsmith devinrsmith

Labels
bug Something isn't working build ci triage
Projects
None yet
Milestone
2. April 2024
Development

Successfully merging a pull request may close this issue.

fix: update to setup-gradle devinrsmith/deephaven-core
2 participants
@niloc132 @devinrsmith