fix: update to setup-gradle #5905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This upgrades from the no longer maintained action `burrunan/gradle-cache-action` to the gradle maintained action `gradle/actions/setup-gradle`. There is a different usage pattern; with `setup-gradle`, it is invoked first during setup as opposed to at the command site. We were also using job-ids with `burrunan/gradle-cache-action` to implicitly control cache prefixes; it is not clear if we actually need to separate caches, and so (for now), the default caching behavior of `gradle/actions/setup-gradle` is used, https://github.com/gradle/actions/blob/v3.5.0/docs/setup-gradle.md#caching-build-state-between-jobs. By default, the action will read from cache, but will only write to the cache for jobs on the `main` branch. Fixes deephaven#5161
devinrsmith
added
NoDocumentationNeeded
NoReleaseNotesNeeded
|
A nightlies run has succeeded, and I don't see any negative change in build time. |
devinrsmith
requested review from
jcferretti,
JamesXNelson,
mofojed and
rcaudy
as code owners
niloc132
reviewed
Aug 6, 2024
| @@ -29,6 +29,9 @@ jobs: | |||
| distribution: 'temurin' | |||
| java-version: '17' | |||
|
|
|||
| - name: Setup Gradle | |||
| uses: gradle/actions/setup-gradle@v3 | |||
There was a problem hiding this comment.
Looks like these should all be version 4.
Suggested change
| uses: gradle/actions/setup-gradle@v3 | |
| uses: gradle/actions/setup-gradle@v4 |
There was a problem hiding this comment.
v4 is an RC candidate right now, noted in #5898
There was a problem hiding this comment.
Hmm okay - their readme suggests v4, so I assumed it was ready for prime time.
niloc132
approved these changes
Aug 7, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrades from the no longer maintained action
burrunan/gradle-cache-actionto the gradle maintained actiongradle/actions/setup-gradle. There is a different usage pattern; withsetup-gradle, it is invoked first during setup as opposed to at the command site. We were also using job-ids withburrunan/gradle-cache-actionto implicitly control cache prefixes; it is not clear if we actually need to separate caches, and so (for now), the default caching behavior ofgradle/actions/setup-gradleis used, https://github.com/gradle/actions/blob/v3.5.0/docs/setup-gradle.md#caching-build-state-between-jobs. By default, the action will read from cache, but will only write to the cache for jobs on themainbranch.Fixes #5161