Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure CI works after docker-compose removal from GH ubuntu-22.04 #5320

Closed
devinrsmith opened this issue Apr 3, 2024 · 0 comments · Fixed by #5322
Closed

Ensure CI works after docker-compose removal from GH ubuntu-22.04 #5320

devinrsmith opened this issue Apr 3, 2024 · 0 comments · Fixed by #5322
Assignees
@devinrsmith
Labels
ci feature request New feature or request
Milestone
1. March 2024

Comments

@devinrsmith
Copy link
Member

See actions/runner-images#9557
@devinrsmith devinrsmith added feature request New feature or request ci labels Apr 3, 2024
@devinrsmith devinrsmith added this to the 1. March 2024 milestone Apr 3, 2024
@devinrsmith devinrsmith self-assigned this Apr 3, 2024
devinrsmith added a commit to devinrsmith/deephaven-core that referenced this issue Apr 3, 2024
@devinrsmith
Upgrade to docker compose v2
0b72bf2 
This upgrades the gradle-docker-compose-plugin to support docker compose v2 by default. The important release notes are https://github.com/avast/gradle-docker-compose-plugin/releases/tag/0.17.0, although we are updating to the latest 0.17.6. Some manual configuration of dockerCompose was needed to workaround avast/gradle-docker-compose-plugin#393.

Additionally, this upgrades all of our docker-compose.yml files to be proper v2 files by removing the version. The docker compose version is only relevant for docker-compose (v1). See https://docs.docker.com/compose/intro/history/ for clarification. This was discovered based on the warning from the `docker compose` process, which would otherwise warn:

```
> Task :Integrations:composeBuild
time="2024-04-03T12:09:28-07:00" level=warning msg="/home/devin/dev/deephaven/deephaven-core/Integrations/docker-compose.yml: `version` is obsolete"
```

Fixes deephaven#5320
@devinrsmith devinrsmith mentioned this issue Apr 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@devinrsmith devinrsmith

Labels
ci feature request New feature or request
Projects
None yet
Milestone
1. March 2024
Development

Successfully merging a pull request may close this issue.

Upgrade to docker compose v2 devinrsmith/deephaven-core
1 participant
@devinrsmith