Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to docker compose v2 #5322

Merged

Conversation

devinrsmith
Copy link
Member

@devinrsmith devinrsmith commented Apr 3, 2024

This upgrades the gradle-docker-compose-plugin to support docker compose v2 by default. The important release notes are https://github.com/avast/gradle-docker-compose-plugin/releases/tag/0.17.0, although we are updating to the latest 0.17.6. Some manual configuration of dockerCompose was needed to workaround avast/gradle-docker-compose-plugin#393.

Additionally, this upgrades all of our docker-compose.yml files to be proper v2 files by removing the version. The docker compose version is only relevant for docker-compose (v1). See https://docs.docker.com/compose/intro/history/ for clarification. This was discovered based on the warning from the docker compose process, which would otherwise warn:

> Task :Integrations:composeBuild
time="2024-04-03T12:09:28-07:00" level=warning msg="/home/devin/dev/deephaven/deephaven-core/Integrations/docker-compose.yml: `version` is obsolete"

Fixes #3554
Fixes #5320

This upgrades the gradle-docker-compose-plugin to support docker compose v2 by default. The important release notes are https://github.com/avast/gradle-docker-compose-plugin/releases/tag/0.17.0, although we are updating to the latest 0.17.6. Some manual configuration of dockerCompose was needed to workaround avast/gradle-docker-compose-plugin#393.

Additionally, this upgrades all of our docker-compose.yml files to be proper v2 files by removing the version. The docker compose version is only relevant for docker-compose (v1). See https://docs.docker.com/compose/intro/history/ for clarification. This was discovered based on the warning from the `docker compose` process, which would otherwise warn:

```
> Task :Integrations:composeBuild
time="2024-04-03T12:09:28-07:00" level=warning msg="/home/devin/dev/deephaven/deephaven-core/Integrations/docker-compose.yml: `version` is obsolete"
```

Fixes deephaven#5320
@devinrsmith devinrsmith added this to the 1. March 2024 milestone Apr 3, 2024
@devinrsmith devinrsmith self-assigned this Apr 3, 2024
@devinrsmith
Copy link
Member Author

I've noted release notes / documentation needed. This is mainly wrt the change to docker compose v2 files.

@devinrsmith
Copy link
Member Author

It may be time to do a pass on some of the stuff we have in repo, but don't test or run. For example, I don't know if any of the debezium stuff is still valid.

Copy link
Member

@niloc132 niloc132 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved - I'd still like to see an appropriate place to list you must have docker compose v2 installed to do development and testing with dhc, either here or in the docs repo.

@devinrsmith
Copy link
Member Author

Approved - I'd still like to see an appropriate place to list you must have docker compose v2 installed to do development and testing with dhc, either here or in the docs repo.

We do have this in our README:

Built from source

Users who wish to modify source code and contribute to the project should build Deephaven from source. For complete instructions, see How to build Deephaven from source.

Building and running Deephaven requires a few software packages.

Package Version OS Required/Recommended
git ^2.25.0 All Required
java >=11, <20 All Required
docker ^20.10.8 All Required
docker compose ^2 All Recommended
Windows 10 (OS build 20262 or higher) Only Windows Required
WSL 2 Only Windows Required

@devinrsmith devinrsmith merged commit 61ae61b into deephaven:main Apr 3, 2024
15 checks passed
@devinrsmith devinrsmith deleted the upgrade-to-docker-compose-v2 branch April 3, 2024 22:32
@deephaven-internal
Copy link
Contributor

Labels indicate documentation is required. Issues for documentation have been opened:

Community: deephaven/deephaven-docs-community#183

@github-actions github-actions bot locked and limited conversation to collaborators Apr 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants