Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JAVA_PUBLIC_SHADOW projects aren't in the bom, and get an unnecessary classifier added #5547

Closed
niloc132 opened this issue May 30, 2024 · 0 comments · Fixed by #5548
Closed
Assignees
Labels
Milestone

Comments

@niloc132
Copy link
Member

The psk auth plugin is deployed to maven central, as a PUBLIC project, but doesn't appear in the bom

https://search.maven.org/artifact/io.deephaven/deephaven-bom/0.34.3/pom

The deephaven-server project explicitly depends on it in gradle, and the pom appears to depend on it:

https://search.maven.org/artifact/io.deephaven/deephaven-server/0.34.3/pom

However, Gradle deploys the psk dependency to central as packaging=pom, and classifier=all to get the jar itself. This means that the deephaven-server dependency will not have the psk present at runtime as specfied, when loaded from maven central, though it will correctly have it when run from the deephaven-core project itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants