Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix publication details for shadowed jars #5548

Merged
merged 2 commits into from
May 30, 2024

Conversation

niloc132
Copy link
Member

Fixes #5547

@niloc132
Copy link
Member Author

Tested by invoking publishToMavenLocal and confirming that external projects can correctly depend on our jars.

Copy link
Member

@devinrsmith devinrsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built pre and post PR with

./gradlew bom:generatePomFileForMyPlatformPublication bom:generateMetadataFileForMyPlatformPublication

the diffs for bom/build/publications/myPlatform/module.json and bom/build/publications/myPlatform/pom-default.xml look correct.

@devinrsmith devinrsmith added this to the 3. May 2024 milestone May 30, 2024
@niloc132 niloc132 force-pushed the 5547-working-downstream-psk branch from 71017d0 to bfbb73e Compare May 30, 2024 20:30
@niloc132 niloc132 enabled auto-merge (squash) May 30, 2024 20:32
@niloc132
Copy link
Member Author

niloc132 commented May 30, 2024

Details for documentation: authentication plugins need to be updated so that their URLs do not end in -all.jar, but just .jar going forward, starting in 0.35 release.

@niloc132 niloc132 merged commit 770440b into deephaven:main May 30, 2024
14 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 30, 2024
@deephaven-internal
Copy link
Contributor

Labels indicate documentation is required. Issues for documentation have been opened:

Community: deephaven/deephaven-docs-community#223

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JAVA_PUBLIC_SHADOW projects aren't in the bom, and get an unnecessary classifier added
3 participants