Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manage testcontainer images versions #5592

Closed
devinrsmith opened this issue Jun 10, 2024 · 0 comments · Fixed by #5593
Closed

Manage testcontainer images versions #5592

devinrsmith opened this issue Jun 10, 2024 · 0 comments · Fixed by #5593
Assignees
@devinrsmith
Labels
feature request New feature or request triage
Milestone
Triage

Comments

@devinrsmith
Copy link
Member

We should be able to manage testcontainer image versions centrally under docker/registry/ as we do with other docker image versions. This will allow us to bump the image version SHAs explicitly as we do with our other docker images.
@devinrsmith devinrsmith added feature request New feature or request triage labels Jun 10, 2024
@devinrsmith devinrsmith added this to the 3. Triage milestone Jun 10, 2024
@devinrsmith devinrsmith self-assigned this Jun 10, 2024
devinrsmith added a commit to devinrsmith/deephaven-core that referenced this issue Jun 10, 2024
@devinrsmith
Adds docker registry projects for localstack and minio
0d06f03 
This allows us to version the testcontainer images just like we version our other docker images.

To ensure our local image names work, we need to inform testcontainers that they are in fact compatible images via `org.testcontainers.utility.DockerImageName#asCompatibleSubstituteFor`.

A `Docker#localImageName` utility was added and propogated to locations where we previously manually constructing or hardcoding the "local-build" image names.

Fixes deephaven#5592
@devinrsmith devinrsmith mentioned this issue Jun 10, 2024
Merged
devinrsmith added a commit that referenced this issue Jun 11, 2024
@devinrsmith
Adds docker registry projects for localstack and minio (#5593)
198e673 
This allows us to version the testcontainer images just like we version our other docker images.

To ensure our local image names work, we need to inform testcontainers that they are in fact compatible images via org.testcontainers.utility.DockerImageName#asCompatibleSubstituteFor.

A Docker#localImageName utility was added and propogated to locations where we previously manually constructing or hardcoding the "local-build" image names.

Fixes #5592
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@devinrsmith devinrsmith

Labels
feature request New feature or request triage
Projects
None yet
Milestone
Triage
Development

Successfully merging a pull request may close this issue.

Adds docker registry projects for localstack and minio devinrsmith/deephaven-core
1 participant
@devinrsmith